Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing QGIS Project with PHP XMLReader instead of DOM #4819

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Oct 1, 2024

Instead of using PHP SimpleXml API to parse QGIS Project, we uses XMLReader. The reason to change it, it is to have something faster and lighter.

@rldhont rldhont added the php Pull requests that update Php code label Oct 1, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Oct 1, 2024
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch 4 times, most recently from 6d91035 to a945350 Compare October 4, 2024 14:24
@rldhont rldhont added the run end2end If the PR must run end2end tests or not label Oct 4, 2024
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch 4 times, most recently from 7fb7fbb to 5f41698 Compare October 8, 2024 16:53
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch from 5f41698 to bd0ebbc Compare October 11, 2024 07:11
@Gustry Gustry modified the milestones: 3.9.0, 3.10.0 Oct 15, 2024
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch 2 times, most recently from 519331c to c5e65cf Compare October 15, 2024 16:31
@rldhont rldhont marked this pull request as ready for review October 15, 2024 16:32
@rldhont
Copy link
Collaborator Author

rldhont commented Oct 15, 2024

@mdouchin @nworr ready for review

@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch 3 times, most recently from 5fc6f9c to 1dd5725 Compare October 18, 2024 12:19
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch from 1dd5725 to 7015b2c Compare October 30, 2024 18:38
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch from 7015b2c to d58aa3b Compare November 15, 2024 09:09
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch from d58aa3b to d7a68d7 Compare November 15, 2024 13:11
… opacity

To reduce duplicated code :
* methods to load embeded project and layer has been added to Lizmap\Project\Qgis\Layer\EmbeddedLayer
* method getLayerOpacity added to LizmapProject\Qgis\Layer\*Layer
@rldhont rldhont force-pushed the qgis-project-parser-xmlreader branch from 90de9b9 to c119d05 Compare December 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_9 php Pull requests that update Php code refactoring run end2end If the PR must run end2end tests or not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants