Add config extraCredentials.googleServiceAccountKey #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't require this, it could get unset, and if it becomes unset we would error with a harder to understand error message than if we would require this via the schema.
|
I'll go for a merge so I can trial use of this easier in 2i2c-org/infrastructure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to add
extraCredentials.googleServiceAccountKeyat all was considered in #123 (comment). It will make things easier to configure like this, but we end up with more specific config than would require via use ofextraFiles+extraEnv.I recorded a video developing this in https://www.youtube.com/watch?v=rNE-XV9RNY0, and pushed a small schema commit (470611b) after recording the video.