Lya multiple scattering #534
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanflitter
added
the
type: feature: physical
for more information, see https://pre-commit.ci
Bencher Report
…d to introduce two new 4D arrays for LW flux as LW photons travel in straight lines). Also included USE_ADIABATIC_FLUCTUATIONS to allow the possibility to begin the simulation with homogeneous T_k
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 87.99% 87.68% -0.32%
==========================================
Files 31 31
Lines 4556 4595 +39
Branches 773 781 +8
==========================================
+ Hits 4009 4029 +20
- Misses 388 403 +15
- Partials 159 163 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for the Lya multiple scattering branch.$\alpha$ and $\beta$ , are determined by the current redshift $z$ , the filter radius $R$ and the ionization fraction $x_\mathrm{HI}$ . Unfortunately GSL doesn't support computing 2F3 so I had to come up with my own implementation, which works pretty well based on the tests that I made.$\alpha\gg\beta$ , as in this limit 2F3 approaches the Bessel function. This configuration should be used only as a sanity check that the new window function (multiple scattering = MS) yields the same output as the old one (straight line = SL) in the appropriate limit.
There are now two new flags, called
LYA_MULTIPLE_SCATTERINGandTEST_SL_WITH_MS_FILTER, the latter becomes relevant only when the former is True, while the former is relevant only ifUSE_HALO_FIELD=True.When
LYA_MULTIPLE_SCATTERING=True, ifTEST_SL_WITH_MS_FILTER=False, the code uses a modified window function that replaces the window function of Eq. (22) in Davies, Mesinger, Murray 2025 (it replaces only the window function that is applied on the SFRD, not the one that is applied on X-ray luminosity). It is a subtraction of two hypergeometric functions 2F3 (instead of a subtraction of two Bessel functions) where the parameters of 2F3,When
LYA_MULTIPLE_SCATTERING=True, andTEST_SL_WITH_MS_FILTER=True, the code uses the same modified window function but withCurrently, this branch is designed to work only when
USE_MINI_HALOS=False. With mini-halos, the SFRD is also used for the Lyman-Werner feedback, but the applied filter should correspond to the old one (as LW photons travel in straight lines), which is not supported by the current implementation whenLYA_MULTIPLE_SCATTERING=True. In the future, two new more fields inXraySourceBox(likefiltered_sfr_lwandfiltered_sfr_lw_mini) should be introduced in this setting (thereby increasing the amount of used memory), or alternatively we can throw an error whenUSE_MINI_HALOSandLYA_MULTIPLE_SCATTERINGare both True.