Only remove the segment at 0x0 if it is added by the debugger. Fix Ve…

…ctor35#590
1ikeadragon · Jul 10, 2024 · f6fd36a · f6fd36a
1 parent 935bfae
commit f6fd36a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/core/debuggercontroller.cpp b/core/debuggercontroller.cpp
@@ -1046,6 +1046,8 @@ DebugStopReason DebuggerController::RunToAndWait(const std::vector<uint64_t>& re
 bool DebuggerController::CreateDebuggerBinaryView()
 {
 	BinaryViewRef data = GetData();
+    auto segment = data->GetSegmentAt(0);
+    m_zeroSegmentAddedByDebugger = segment == nullptr;
 	m_accessor = new DebuggerFileAccessor(data);
 	data->GetMemoryMap()->AddRemoteMemoryRegion("debugger", 0, m_accessor);
 	return true;
@@ -2524,9 +2526,12 @@ bool DebuggerController::RemoveDebuggerMemoryRegion()
 	if (!ret)
 		return false;
 
-	auto segment = m_data->GetSegmentAt(0);
-	if (segment)
-		m_data->RemoveAutoSegment(segment->GetStart(), segment->GetLength());
+    if (m_zeroSegmentAddedByDebugger)
+    {
+        auto segment = m_data->GetSegmentAt(0);
+        if (segment)
+            m_data->RemoveAutoSegment(segment->GetStart(), segment->GetLength());
+    }
 
 	return true;
 }

diff --git a/core/debuggercontroller.h b/core/debuggercontroller.h
@@ -149,6 +149,8 @@ namespace BinaryNinjaDebugger {
 		std::string m_lastAdapterName;
 		std::string m_lastCommand;
 
+        bool m_zeroSegmentAddedByDebugger = false;
+
 		void DetectLoadedModule();
 
 	public: