Use the MemoryMap API to represent the memory regions for the debugger.

Fix Vector35#213
1ikeadragon · Jun 19, 2024 · f5389dd · f5389dd
1 parent dfd8b2b
commit f5389dd
Show file tree

Hide file tree

Showing 16 changed files with 358 additions and 498 deletions.
diff --git a/api/debuggerapi.h b/api/debuggerapi.h
@@ -593,6 +593,11 @@ namespace BinaryNinjaDebuggerAPI {
 		bool IsTTD();
 
 		void PostDebuggerEvent(const DebuggerEvent& event);
+
+		bool RemoveDebuggerMemoryRegion();
+		bool ReAddDebuggerMemoryRegion();
+
+		uint64_t GetViewFileSegmentsStart();
 	};
 
 

diff --git a/api/debuggercontroller.cpp b/api/debuggercontroller.cpp
@@ -912,3 +912,21 @@ void DebuggerController::PostDebuggerEvent(const DebuggerEvent &event)
 	BNDebuggerFreeString(evt->data.messageData.message);
 	delete evt;
 }
+
+
+bool DebuggerController::RemoveDebuggerMemoryRegion()
+{
+	return BNDebuggerRemoveMemoryRegion(m_object);
+}
+
+
+bool DebuggerController::ReAddDebuggerMemoryRegion()
+{
+	return BNDebuggerReAddMemoryRegion(m_object);
+}
+
+
+uint64_t DebuggerController::GetViewFileSegmentsStart()
+{
+	return BNDebuggerGetViewFileSegmentsStart(m_object);
+}
diff --git a/api/ffi.h b/api/ffi.h
@@ -491,6 +491,11 @@ extern "C"
 
 	DEBUGGER_FFI_API void BNDebuggerPostDebuggerEvent(BNDebuggerController* controller, BNDebuggerEvent* event);
 
+	DEBUGGER_FFI_API bool BNDebuggerRemoveMemoryRegion(BNDebuggerController* controller);
+	DEBUGGER_FFI_API bool BNDebuggerReAddMemoryRegion(BNDebuggerController* controller);
+
+	DEBUGGER_FFI_API uint64_t BNDebuggerGetViewFileSegmentsStart(BNDebuggerController* controller);
+
 	// DebugAdapterType
 	DEBUGGER_FFI_API BNDebugAdapterType* BNGetDebugAdapterTypeByName(const char* name);
 	DEBUGGER_FFI_API bool BNDebugAdapterTypeCanExecute(BNDebugAdapterType* adapter, BNBinaryView* data);

diff --git a/core/debugger.cpp b/core/debugger.cpp
@@ -15,7 +15,6 @@ limitations under the License.
 */
 
 #include <inttypes.h>
-#include "processview.h"
 #include "adapters/lldbadapter.h"
 #ifdef WIN32
 	#include "adapters/dbgengadapter.h"
@@ -181,7 +180,6 @@ extern "C"
 		LogDebug("Native debugger loaded!");
 		RegisterSettings();
 		InitDebugAdapterTypes();
-		InitDebugProcessViewType();
 		return true;
 	}
 }