Fix memory leak on the binary view if the input view is rebased durin…

…g launch
1ikeadragon · Feb 22, 2024 · a214f0e · a214f0e
1 parent cdf533b
commit a214f0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/core/processview.cpp b/core/processview.cpp
@@ -192,7 +192,7 @@ void DebugProcessView::eventHandler(const DebuggerEvent &event)
 
 
 DebugNullView::DebugNullView(BinaryView* parent) :
-	BinaryView("Debugger Null", parent->GetFile(), parent)
+	BinaryView("Debugger Null", parent->GetFile(), nullptr)
 {
 }
 

diff --git a/ui/ui.cpp b/ui/ui.cpp
@@ -1190,15 +1190,9 @@ void DebuggerUI::updateUI(const DebuggerEvent& event)
 			ViewFrame* frame = m_context->getCurrentViewFrame();
 			FileContext* fileContext = frame->getFileContext();
 			fileContext->refreshDataViewCache();
-			auto tab = m_context->getTabForFile(fileContext);
-			ViewFrame* newFrame = m_context->openFileContext(fileContext);
-
-			if (newFrame)
-			{
-				m_context->closeTab(tab);
-				navigateToCurrentIP();
-				QCoreApplication::processEvents();
-			}
+			m_context->recreateViewFrames(fileContext);
+			navigateToCurrentIP();
+			QCoreApplication::processEvents();
 		}
 		else
 		{
-Original file line number
+Diff line change
@@ Expand Up @@
     DebugNullView::DebugNullView(BinaryView* parent) :
-    	BinaryView("Debugger Null", parent->GetFile(), parent)
+    	BinaryView("Debugger Null", parent->GetFile(), nullptr)
     {
     }
@@ Expand Down @@