Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jawn/issue 393 #481

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Jawn/issue 393 #481

merged 8 commits into from
Feb 18, 2024

Conversation

jawndiego
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
river-site ✅ Ready (Inspect) Visit Preview Feb 18, 2024 9:46pm
river-site-metadata ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 9:46pm

Copy link

railway-app bot commented Feb 13, 2024

This PR is being deployed to Railway 🚅

Copy link
Contributor

@0xTranqui 0xTranqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big fan of this pr. would be an even bigger fan if we could use this as an opportunity to remove the getItemPage grahql + request file. I just checked and it looks like its not in use anywhere else. if we can get a deploy up with that gone, and all this working, think we good to merge!

@jawndiego jawndiego merged commit 174b450 into main Feb 18, 2024
5 checks passed
@jawndiego jawndiego deleted the jawn/issue_393 branch February 18, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid making the itemPage query on the item page route
3 participants