Add logic for communicating to Desktop App #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marton6
reviewed
Sep 10, 2025
Marton6
reviewed
Sep 10, 2025
edif2008
force-pushed
the
andi/desktop-integration
branch
3 times, most recently
from
e1778f4 to
a732e9d
Compare
edif2008
force-pushed
the
andi/desktop-integration
branch
from
a732e9d to
72b5315
Compare
edif2008
force-pushed
the
andi/desktop-integration
branch
from
72b5315 to
f238d26
Compare
edif2008
force-pushed
the
andi/desktop-integration
branch
from
f238d26 to
3eab07a
Compare
This is caused by the changes in the 1Password app side in which the return type has been changed.
- async linters are still silenced where applicable - We silence @typescript-eslint/no-var-requires since it's not applicable for our case.
edif2008
force-pushed
the
andi/desktop-integration
branch
from
086320e to
20738e0
Compare
The module is now loaded directly as a dylib. The function we call is now async.
AndyTitu
commented
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR adds logic for handling invoking requests directly though the desktop app, for leveraging the desktop app prompt authentication model for desktop integrations built on top of the SDK.
Thought Process
A new core implementation was added to load a shared lib from the Desktop app bundle used to make IPC calls to the desktop app server. To do that we first attempt for find the path of the desktop app from well known locations.
The client builder api is enriched with an option to specify whether you want a specific client to authenticate via auth prompts.
NOTE: Internal op-codegen will need changes as well since code generated files were modified. But I'm leaving that for after the api is stabilised
How to Test
This can be tested only using an internal desktop app build that spawns an IPC server.