Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stop clock control features in modal #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manojbalaji1
Copy link

PR for IssueID: #18

Added Sto-watch options in popup modal of notes

@1995YogeshSharma
Copy link
Owner

Hi, this is not functionally correct as of now.
Two of the bugs I could see was ->

  • when you add a stopwatch, it is in 'pause mode' and control button also shows option to 'pause' which is not the case in the code before your commit.
  • Switch any clock to modal view and toggle it's mode (say from pause to play). Now when you cross modal the watch reflects the toggled state in modal but the button in main mode doesn't.

@1995YogeshSharma
Copy link
Owner

1995YogeshSharma commented Oct 29, 2019

Please make these changes and I'll remove the 'draft' label immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants