Refactor USWDS alert component into a shortcode. #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adunkman
force-pushed
the
refactor-alerts
branch
from
1347318 to
256b0a2
Compare
This is a cleaner syntax for alerts.
adunkman
force-pushed
the
refactor-alerts
branch
from
256b0a2 to
9d989cc
Compare
mgwalker
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Very nice!
I moved the low-system banners to the tops of pages because we were getting some kind of 11ty Markdown rendering bug on the GSA Pages page. It wanted to render the alert inside a list item and then it... couldn't, for some reason, so half of the alert became additional list items outside of the alert container. Rather than fight 11ty bugs, I opted to just move the alert. The top of the page makes more sense to me anyway. 🤷🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner syntax for alerts — I'm working on introducing a section around TTS Consulting which uses alerts, and this syntax seems much tidier.
Changes proposed in this pull request:
security considerations
None, new shortcode runs only in build.