Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method card updates: change "government considerations" heading, remove "time required", fix layout issue #768

Merged
merged 48 commits into from
Jan 7, 2025

Conversation

michelle-rago
Copy link
Member

@michelle-rago michelle-rago commented Dec 11, 2024

Changes proposed in this pull request:

  • Edited the heading so it's a bit shorter and won't wrap as often: "Considerations for use in government" to "Government considerations"
  • Fixed layout issue for display of all "validate" cards (due to missing closing tag in the first card)
  • Remove "Time required" info from displaying on the cards. This was done by removing that field from method.html. The information about the time required still exists in the front matter of the individual method cards.

Note: Changes to the PRA text under "Government considerations" will be proposed in another PR.

Preview URL

@michelle-rago michelle-rago marked this pull request as ready for review December 11, 2024 19:15
@michelle-rago michelle-rago requested a review from a team as a code owner December 13, 2024 20:13
@michelle-rago michelle-rago requested review from juliaklindpaintner and removed request for amandacostello December 17, 2024 13:08
Copy link
Member

@juliaklindpaintner juliaklindpaintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@michelle-rago
Copy link
Member Author

Now we just need @quarterback approval. 🤞

Copy link
Member

@adunkman adunkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval on behalf of TLC; still awaiting Ron as code owner of Methods.

@michelle-rago michelle-rago changed the title Edit heading for government consideration section on methods Method card updates: change "government considerations" heading, remove "time required", fix layout issue Jan 6, 2025
@michelle-rago
Copy link
Member Author

@quarterback Hi - Do you have time to review this PR as the code owner?

@michelle-rago michelle-rago added the Methods Task related to Methods and/or pulled from the old Methods repo. label Jan 6, 2025
@quarterback quarterback merged commit e636dbe into main Jan 7, 2025
8 checks passed
@quarterback quarterback deleted the mr/edit-gov-considerations-heading branch January 7, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Methods Task related to Methods and/or pulled from the old Methods repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants