Nginx fix #935
Merged
Nginx fix #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2023 10:02
…ted env var replacements
…ted env var replacements 2
|
@XavierMetichecchia - can this be merged into a non-master branch for deployment to dev or staging first? |
@ryanwoldatwork Well I was going to merge it into develop but it seems develop is way behind main. Am I clear to pull main into develop first? |
…ted env var replacements 4
ryanwoldatwork
force-pushed
the
develop
branch
from
690718e
to
5688c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reformats the nginx configuration using new nginx building supported {{env}} replacements as well as removing the erb if statements and using nginx built in statements for "if" conditionals.
This PR is for testing in develop.
Resolves Issue # https://github.com/orgs/18F/projects/55/views/1?pane=issue&itemId=38536224
Describe the pull request here, including any supplemental information needed to understand it.
Impacted Areas of the Site
Nginx configuration
Optional Screenshots
This pull request changes...
This pull request is ready to merge when...