-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1091
Update dependencies #1091
Conversation
Resolves issue on initial setup that complained about mismatched Ruby versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Def might be speaking way out of my league here but I suspect you may have made changes to the Gemfile for the platform because you are likely developing locally on a mac. In the cloud tho it will be an x86 based OS running a Ruby container, just want to make sure this won't mess with any of that. Guess we don't really know until we try! lol
That makes sense. This file was updated after I matched the ruby and bundler versions, so it makes sense to include anyways. |
PLATFORMS | ||
arm64-darwin-23 | ||
x86_64-darwin-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanwoldatwork @XavierMetichecchia thanks for the considerations. I didn't realize the previous platform was removed via bundle install
.
I've reverted that change in 8e5536c and have added my local platform in 52d0489 (via the command bundle lock --add-platform arm64-darwin-23
). This should improve compatibility moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks kosher!
Summary
Dependency updates.
Impacted Areas of the Site
This pull request changes...
Gemfile.lock
file. There was a local issue with mismatched ruby deps.This pull request is ready to merge when...