Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1091

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Update dependencies #1091

merged 5 commits into from
Dec 20, 2023

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Dec 19, 2023

Summary

Dependency updates.

Impacted Areas of the Site

  • Local environment

This pull request changes...

  • Created an NVMRC that matches supported node engine. This will help us stay on the same version of node.
  • Regenerated Gemfile.lock file. There was a local issue with mismatched ruby deps.
  • Updated node minor and patch dependencies. This should resolve current dependabot alerts.

This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • The change has been documented

Copy link
Contributor

@ryanwoldatwork ryanwoldatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def might be speaking way out of my league here but I suspect you may have made changes to the Gemfile for the platform because you are likely developing locally on a mac. In the cloud tho it will be an x86 based OS running a Ruby container, just want to make sure this won't mess with any of that. Guess we don't really know until we try! lol

@mejiaj
Copy link
Contributor Author

mejiaj commented Dec 20, 2023

Def might be speaking way out of my league here but I suspect you may have made changes to the Gemfile for the platform because you are likely developing locally on a mac. In the cloud tho it will be an x86 based OS running a Ruby container, just want to make sure this won't mess with any of that. Guess we don't really know until we try! lol

That makes sense. This file was updated after I matched the ruby and bundler versions, so it makes sense to include anyways.

Comment on lines 79 to 81
PLATFORMS
arm64-darwin-23
x86_64-darwin-21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanwoldatwork @XavierMetichecchia thanks for the considerations. I didn't realize the previous platform was removed via bundle install.

I've reverted that change in 8e5536c and have added my local platform in 52d0489 (via the command bundle lock --add-platform arm64-darwin-23). This should improve compatibility moving forward.

Copy link
Contributor

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks kosher!

@XavierMetichecchia XavierMetichecchia merged commit 50bc1f6 into develop Dec 20, 2023
4 checks passed
@mejiaj mejiaj deleted the jm-update-deps branch December 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants