Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team_members.csv #4082

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Update team_members.csv #4082

merged 3 commits into from
Sep 30, 2024

Conversation

rrefoy
Copy link
Member

@rrefoy rrefoy commented Aug 23, 2024

Edited the URL that points to blog posts done by moi to be corrected to my current name.

https://18f.gsa.gov/author/rebecca-refoy-sidibe/

Pull request summary

Here's what I'm trying to do with this PR: Edited the URL that points to blog posts done by moi to be corrected to my current name.

https://18f.gsa.gov/author/rebecca-refoy-sidibe/ should be https://18f.gsa.gov/author/rebecca-refoy/

Reminder - please do the following before assigning reviewer

  • Update readme
  • For frontend changes, ensure design review
  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

@rrefoy rrefoy requested a review from a team as a code owner August 23, 2024 19:08
@cantsin
Copy link
Member

cantsin commented Aug 23, 2024

The tests/CI did not catch this but with this change, we get rebecca-refoy-sidibe is undefined messages in the output, because that author becomes "unknown" when 11ty processes the blog posts. So I think we'll have to change the author front matter in the relevant blog posts. I'm not too sure if we can do a redirect_from for authors. @beechnut do you know?

@beechnut
Copy link
Contributor

@cantsin The last column of the CSV is redirect_from, so, you in fact can do that! It should autogenerate. Also, I'm surprised that the undefined author error didn't break the build — it should have. Let's open an issue soon.

@rrefoy I noticed that you only changed the slug — did you also want to change your display name?

@nateborr
Copy link
Member

In my local environment, I tried adding a redirect from /author/rebecca-refoy-sidibe/ via the CSV file, but I don't see any evidence that the redirect_from values are being written into the front matter for the generated author pages. @beechnut if that's surprising I can capture a follow-up ticket to look into that (it's possible I'm also interpreting that logic incorrectly).

In any event, to avoid the undefined errors I think we do need to update the author slug to rebecca-refoy in all of the existing blog posts. I can push up that change myself sometime this week.

rrefoy and others added 2 commits September 18, 2024 15:14
Edited the URL that points to blog posts done by moi to be corrected to my current name.

https://18f.gsa.gov/author/rebecca-refoy-sidibe/
Copy link
Member

@edwintorres edwintorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it's working for me.

@nateborr nateborr merged commit d695c7d into main Sep 30, 2024
8 checks passed
@nateborr nateborr deleted the rrefoy-patch-1 branch September 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants