Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner img added #4029

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Banner img added #4029

merged 2 commits into from
Sep 23, 2024

Conversation

a-chappelear
Copy link
Contributor

Pull request summary

Banner img

(Optional) Closes #(issue_number).

Reminder - please do the following before assigning reviewer

  • Update readme
  • For frontend changes, ensure design review
  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

@a-chappelear a-chappelear requested a review from a team as a code owner July 30, 2024 19:24
Copy link
Member

@nateborr nateborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a fix for the image config, and this branch also needs to have a merge conflict manually resolved on the command line. I can do that quickly if you don't have a local environment set up.

@nateborr
Copy link
Member

I rebased this branch onto the latest version of main to resolve a merge conflict from the renaming of the content/posts/2024-07-17-working-with-oracle-databases-in-open-source-projects.md file, and the updated post is rendering correctly.

@nateborr nateborr merged commit 4cf7da4 into main Sep 23, 2024
9 checks passed
@nateborr nateborr deleted the oracle-blog-img branch September 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants