Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.6.10 release notes #594

Merged
merged 14 commits into from
Aug 29, 2023
Merged

5.6.10 release notes #594

merged 14 commits into from
Aug 29, 2023

Conversation

Chr1st0ph3rTurn3r
Copy link
Contributor

No description provided.


- **The following CVE's have been identified and addressed in this release:** I95-51758, I95-52495, I95-52497, I95-52509.
------
- **I95-51336 App-ID stats entry leaked in some session building exceptions:** Resolved an issue where the `app-id stats` entry was not added to the `Expiring` list to be cleaned up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the Jira talks about "stats entries are being leaked", this really amount to a memory leak.
I95-51336 App-ID memory leak for some uncommon cases, such a duplicate flow: Resolved an issue where the app-id stats entry was not added to the Expiring list to be cleaned up.

------
- **I95-51800 Radius authentication failure - Incorrect NAS IP address:** The ability to specify the NAS-IP-Address and NAS-Identifier has been added to the data model for configuring these Radius options per node. This can be used in cases where the Radius server is configured to use an identifier, or in cases where it is necessary to match the source IP address of the Radius requests behind SSR or NAT.
------
- **I9552208 Queries return incomplete data with FIPS enabled:** Resolved an issue where a FIPS-incompatible hashing function was causing missing or incomplete metrics data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What queries? Also, missing hyphen
**I95-52208 metrics queries return incomplete data when FIPS is enabled: Resolved an issue where a FIPS-incompatible hashing function was causing missing or incomplete metrics data.

@MichaelBaj MichaelBaj self-requested a review August 9, 2023 20:06
MichaelBaj
MichaelBaj previously approved these changes Aug 9, 2023
@MichaelBaj MichaelBaj self-requested a review August 18, 2023 19:13
- **The following CVE's have been identified and addressed in this release:** I95-51758, I95-52495, I95-52497, I95-52509.
- **The following CVE's have been identified and addressed in this release:** I95-51758, I95-52495, I95-52496, I95-52497, I95-52509, I95-52625.
------
- **I95-41386/I95-52114 HA pair device interface's redundancy status stays non-redundant even though the interface operational status is up:** Resolved an issue where zookeepper enters a leaderless state when a disconnection occurs right after an electorate ephemeral node is created, and before running a success callback.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rewording

  • I95-41386/I95-52114 HA pair device interface's redundancy status stays non-redundant even though the interface operational status is up after both nodes simultaneously come online, as in the case of power failures: Resolved a race condition where zookeepper enters a leaderless state when a disconnection occurs right after an electorate ephemeral node is created, and before running a success callback.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "zookeeper" is misspelled as "zookeepper" in both the original and your rewording.
  2. Do these internal details about zookeeper and such really mean anything to customers?

------
- **I95-52626 Forwarding plane control message bursts create exception, causing a packet buffer leak:** Resolved a condition where backpressure from fastlane caused the messaging mechanism between highway manager and fastlane to drop mbufs. Proper handling of exception now prevents buffer leaks. Additionally, increased the control buffer capacity to better handle bursts as part of the resolution.
------
- **I95-52650 Create a cache of the common file root hash calculation:** An optimization was made to an internal calculation and improve the speed at which synchronization requests are processed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rewording:

  • I95-52650 Asset state transition on conductor is slow for deployments with greater than 250 routers: An optimization was made to an internal calculation and improve the speed at which synchronization requests are processed.


### New Features

- **I95-52198 Handle incoming public keys from peer conductor node:** Added functionality to allow conductor nodes to share the authorized keys of managed routers between each other. If the SSH public key is retrieved from a managed router by one conductor node then it will be automatically shared with it's conductor peer node.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word "it's" at the end of the paragraph should be "its".

------
- **I95-52402 Router stuck in `Upgrading` state:** Resolved an issue with `conductor-only` mode, where the conductor was attempting to download the installer before the software access proxies were in place, preventing an update to the installer.
------
- **I95-52626 Forwarding plane control message bursts create exception, causing a packet buffer leak:** Resolved a condition where backpressure from fastlane caused the messaging mechanism between highway manager and fastlane to drop mbufs. Proper handling of exception now prevents buffer leaks. Additionally, increased the control buffer capacity to better handle bursts as part of the resolution.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, I'm not sure we should be documenting this level of internal details, which are not meaningful to customers.

@MichaelBaj MichaelBaj self-requested a review August 28, 2023 14:54
Copy link
Contributor

@MichaelBaj MichaelBaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to make requested changes.

… Added the Configuration Command Guide, a generated file listing all the configuration pcli commands. This is a complete listing of all the config commands.

- **The following CVE's have been identified and addressed in this release:** I95-51758, I95-52495, I95-52496, I95-52497, I95-52509, I95-52625.
------
- **I95-41386/I95-52114 HA pair device interface's redundancy status stays non-redundant even though the interface operational status is up:** Resolved a race condition where a disconnection occurs right after an electorate ephemeral node is created, and before running a success callback.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolution isn't meaningful to customers; I suggest it be:

"Resolved a race condition when selecting the active components between HA nodes."

------
- **I95-52305 Compacting rate limit exceeded:** Resolved memory and CPU issues resulting from attempting to compact very large application identification documents.
------
- **I95-52316 Enhancements to Overlapping FIB Services:** When creating FIB entries, we now consider services that match the route update but do not have the best match service address.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this requires setting an authority-wide configuration knob, no?

------
- **I95-52402 Router stuck in `Upgrading` state:** Resolved an issue with `conductor-only` mode, where the conductor was attempting to download the installer before the software access proxies were in place, preventing an update to the installer.
------
- **I95-52626 Forwarding plane control message bursts create exception, causing a packet buffer leak:** Resolved a condition where backpressure caused the messaging mechanism to develop buffer leaks. Proper handling of exceptions now prevents buffer leaks. Additionally, increased the control buffer capacity to better handle bursts as part of the resolution.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the "Additionally, ..." last sentence.

Bhautik
Bhautik previously approved these changes Aug 29, 2023
@@ -275,6 +275,7 @@ module.exports = {
],
"CLI and Element Reference": [
"cli_reference",
"config_command_guide",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing before? Secret file?

@Chr1st0ph3rTurn3r Chr1st0ph3rTurn3r merged commit 1df2d7f into master Aug 29, 2023
1 check passed
@Chr1st0ph3rTurn3r Chr1st0ph3rTurn3r deleted the 5.6.10-release-notes branch August 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants