Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing references to version 4.x software #592

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

Chr1st0ph3rTurn3r
Copy link
Contributor

No description provided.

@@ -8,10 +8,6 @@ import { columns, releases, moduleTests } from "./releases.table";

:::info
Issues resolved in a release are merged into subsequent releases chronologically AND lexicographically.

For example, issues resolved in `4.3.12`, which was released on 3/12/2021, are resolved in `4.5.6`, which was released on 3/26/2021 and also resolved in `5.1.0`, which was released on 3/15/2021, and so on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software versions referenced here are necessary to explain software release mechanics. It is just coincidence that they are referencing 4.x software. I would either leave this section or update it with an updated version of software to illustrate the same point.

@@ -43,13 +39,6 @@ Version `6.1.0` introduces changes to the SSR software release model. Every six
| Release 5.2 | May 10, 2021 | November 10, 2021 | May 10, 2022 |
| Release 5.1 | May 17, 2021 | August 24, 2022 | February 24, 2023 |
| Release 5.0 | December 18, 2020 | June 18, 2021 | December 18, 2021 |
| Release 4.5 | July 23, 2020 | April 15, 2021 | October 15, 2021 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is to identify versions of software that are out of support. In this case, we do want to indicate that these versions are no longer supported.

@@ -1,56 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -1,961 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -1,925 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -1,790 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -1,463 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -1,760 +0,0 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -295,16 +295,6 @@ export const releases = [
url: '/docs/release_notes_128t_5.1#release-514',
releaseDate: 'July 7, 2021',
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still show as being removed from the sidebar.

sidebars.js Outdated
@@ -318,12 +318,6 @@ module.exports = {
"release_notes_128t_5.2",
"release_notes_128t_5.1",
"release_notes_128t_5.0",
"release_notes_128t_4.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Junos does not remove old release notes. As far as I can tell, they are kept indefinitely.
The point of this exercise is to remove incorrect or irrelevant references.

@@ -295,16 +295,6 @@ export const releases = [
url: '/docs/release_notes_128t_5.1#release-514',
releaseDate: 'July 7, 2021',
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still show as being removed from the sidebar.

@Chr1st0ph3rTurn3r Chr1st0ph3rTurn3r merged commit 44bdee4 into master Aug 2, 2023
1 check passed
@Chr1st0ph3rTurn3r Chr1st0ph3rTurn3r deleted the version-4.x-removal branch August 2, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants