[TECH] Supprime la colonne partnerKey (PIX-10162 ) #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceol
force-pushed
the
pix-10162-remove-partnerKey-column
branch
from
1a49980 to
a1134e7
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
aceol
force-pushed
the
pix-10162-remove-partnerKey-column
branch
2 times, most recently
from
d78cc49 to
e042f11
Compare
aceol
added
👀 Tech Review Needed
👀 Func Review Needed
aceol
force-pushed
the
pix-10162-remove-partnerKey-column
branch
from
e042f11 to
e927fb5
Compare
Osirisxxl
approved these changes
Dec 12, 2023
matthieu-octo
approved these changes
Dec 13, 2023
Steph0
force-pushed
the
pix-10162-remove-partnerKey-column
branch
from
e927fb5 to
9fe90d0
Compare
|
Tech func avec @mariannebost ✅ Sur Certif déjà passée
Sur session créée, passage de CléA
|
Steph0
added
Func Review OK
mariannebost
approved these changes
Dec 14, 2023
Steph0
force-pushed
the
pix-10162-remove-partnerKey-column
branch
from
9fe90d0 to
4a95d4e
Compare
Steph0
approved these changes
Dec 15, 2023
pix-service-auto-merge
deleted the
pix-10162-remove-partnerKey-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Suite à #7447 la colonne partnerKey n'est plus utilisée
🎁 Proposition
La supprimer
🧦 Remarques
Il restait quelques references inutiles, principalement dans les tests
Il reste par ailleurs des "partnerKey" dans les certification-challenges. On pourrait les supprimer mais cela nécessite un travail approfondie. A faire dans une autre PR
🎅 Pour tester
Faire le parcours classique de certif complementaire, verifier que l'affichage sur admin et sur les certificats est ok
([email protected])
([email protected] & [email protected])