Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Afficher uniquement un grain à la fois (PIX-9894) #7476

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

dlahaye
Copy link
Contributor

@dlahaye dlahaye commented Nov 17, 2023

🦄 Problème

Actuellement, dans le contexte des modules sur Pix App, nous affichons tous les grains en même temps. Cela peut être impressionnant et rebuter les utilisateurs à poursuivre leur apprentissage.

🤖 Proposition

Nous décidons d'afficher un grain à la fois, et d'afficher le bouton continuer uniquement quand les activités du grain sont finies.

🌈 Remarques

  • Nous décidons de focus dès le premier grain, nous itérerons par la suite pour améliorer ce comportement

💯 Pour tester

  • Su Pix App, se rendre sur /modules/bien-ecrire-son-adresse-mail
  • Constater qu'après avoir cliqué sur le bouton "Continuer" le grain suivant s'affiche
  • Quand il s'agit du dernier grain le bouton "continuer" ne s'affiche pas

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@reibecca reibecca force-pushed the pix-9894-display-one-grain-at-a-time branch from b3cd09b to 9cda256 Compare November 17, 2023 14:36
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch 3 times, most recently from 7d8dd83 to 38d9a31 Compare November 17, 2023 16:41
@dlahaye dlahaye force-pushed the pix-9894-display-one-grain-at-a-time branch from 466fa4c to b4e0e72 Compare November 20, 2023 15:39
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch from b4e0e72 to 2d2a96c Compare November 20, 2023 16:34
@@ -11,4 +11,8 @@ export default class Element extends Model {
get isQcu() {
return this.type === 'qcus';
}

get isAnswerable() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce champ devrait être renvoyé par l'API

@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch 3 times, most recently from a13f3b0 to b0b6cac Compare November 21, 2023 08:11
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch from 471917f to 31d5479 Compare November 21, 2023 11:05
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch 5 times, most recently from 7bb0b75 to eceac11 Compare November 23, 2023 10:56
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch 2 times, most recently from a202de8 to f503a69 Compare November 23, 2023 11:48
@yannbertrand
Copy link
Member

Le bouton "vérifier" du QCU ne disparaît plus après envoi de la réponse

@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch from f503a69 to f9b212c Compare November 23, 2023 15:43
@mirawlin
Copy link
Contributor

Je pense on a pas encore fait les tracking Matomo pour le bouton continuer

@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch 2 times, most recently from d92755b to 209492d Compare November 23, 2023 20:18
@VincentHardouin VincentHardouin force-pushed the pix-9894-display-one-grain-at-a-time branch from 209492d to 702f170 Compare November 24, 2023 09:40
@dlahaye dlahaye added 🚀 Ready to Merge Tech Review OK Func Review OK PO validated functionally the PR and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Nov 24, 2023
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-9894-display-one-grain-at-a-time branch 3 times, most recently from deae2f4 to b0e4ce0 Compare November 24, 2023 14:28
VincentHardouin and others added 5 commits November 24, 2023 14:35
Co-authored-by: Dimitri Lahaye <[email protected]>
Co-authored-by: Miranda Lin-Guignard <[email protected]>
…onent args

Co-authored-by: Dimitri Lahaye <[email protected]>
Co-authored-by: Miranda Lin-Guignard <[email protected]>
Co-authored-by: Dimitri Lahaye <[email protected]>
Co-authored-by: Miranda Lin-Guignard <[email protected]>
Co-authored-by: Dimitri Lahaye <[email protected]>
Co-authored-by: Miranda Lin-Guignard <[email protected]>
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-9894-display-one-grain-at-a-time branch from b0e4ce0 to a8b851e Compare November 24, 2023 14:35
@pix-service-auto-merge pix-service-auto-merge merged commit 9f264f6 into dev Nov 24, 2023
3 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-9894-display-one-grain-at-a-time branch November 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants