[TECH] Migrer en GJS les composants organization-learners de pixOrga (Pix 15749)
#10834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Alexandre-Monney
approved these changes
Dec 17, 2024
| import Component from '@glimmer/component'; | ||
| import Date from '../../ui/date'; | ||
| import ParticipationStatus from '../../ui/participation-status'; | ||
| import Type from '../../campaign/detail/type'; |
There was a problem hiding this comment.
nitpick: Appeler ce composant CampaignType serait un peu plus explicite ?
Comment on lines
21
to
25
| <p>{{t | ||
| "pages.organization-learner.activity.empty-state" | ||
| organizationLearnerFirstName=this.firstName | ||
| organizationLearnerLastName=this.lastName | ||
| }}</p> |
There was a problem hiding this comment.
Suggested change
| <p>{{t | |
| "pages.organization-learner.activity.empty-state" | |
| organizationLearnerFirstName=this.firstName | |
| organizationLearnerLastName=this.lastName | |
| }}</p> | |
| <p>{{t | |
| "pages.organization-learner.activity.empty-state" | |
| organizationLearnerFirstName=(capitalize @firstName) | |
| organizationLearnerLastName=(capitalize @lastName) | |
| }}</p> |
Je pense que tu peux faire comme ça. Et du coup tu peux supprimer les deux getters et ne plus passer par une classe pour ce composant ci 😇
| @@ -0,0 +1,37 @@ | |||
| import ParticipationRow from './participation-row'; | |||
| import Header from '../../table/header'; | |||
There was a problem hiding this comment.
nitpick: Pareil que le commentaire précédent, appeler ce composant TableHeader?
machestla
force-pushed
the
PIX-15749-change-js-and-hbs-into-gjs-component
branch
from
5a5e1b2 to
0307011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Le format GJS va devenir le format par défaut d'ici la fin de l'édition Polaris de Ember
🎁 Proposition
Faire la migration des composants du dossier
organizationLearnerde Pix Orga au format GJS🧦 Remarques
🎅 Pour tester