-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Rendre asynchrone l'import à format sur PixOrga (Pix-15437) #10827
Open
xav-car
wants to merge
9
commits into
dev
Choose a base branch
from
pix-15437/asynchronize-import-generic
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-15437/asynchronize-import-generic
branch
3 times, most recently
from
December 17, 2024 07:50
0e8f4e4
to
39d2757
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Dec 17, 2024
lionelB
reviewed
Dec 17, 2024
...agement/unit/domain/usecases/import-from-feature/validate-organization-learners-file_test.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Dec 17, 2024
api/src/prescription/learner-management/application/organization-learners-controller.js
Outdated
Show resolved
Hide resolved
lionelB
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ TECH OK
func ok ✅ |
xav-car
force-pushed
the
pix-15437/asynchronize-import-generic
branch
from
December 17, 2024 13:44
39d2757
to
b245178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Un village d'irréductible usecases sont toujours en synchrone ne permettant pas au captains de pouvoir mettre en pause TOUS les imports lors de la montée en charge de l'Application
🎁 Proposition
Tout le monde passe à l'asynchronie, même ces 2 derniers usecase d'import à format générique
🧦 Remarques
RAS
🎅 Pour tester
Faire un import à format Generic. et vérifier que l'import est réalisé.
Vérifier que nous avons bien les jobs dans pgboss