[TECH] Utiliser de fausses données pour les test du script get-elements-csv (PIX-15633) #10819
+396
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yannbertrand
approved these changes
Dec 16, 2024
dianeCdrPix
force-pushed
the
pix-15633-use-deterministic-data-for-script-test
branch
2 times, most recently
from
8d21868 to
c3d3fe1
Compare
dianeCdrPix
approved these changes
Dec 17, 2024
dianeCdrPix
approved these changes
Dec 17, 2024
Co-authored-by: Eric Lim <[email protected]> Co-authored-by: Diane Cordier <[email protected]>
Co-authored-by: Eric Lim <[email protected]> Co-authored-by: Diane Cordier <[email protected]>
Co-authored-by: Eric Lim <[email protected]> Co-authored-by: Diane Cordier <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-15633-use-deterministic-data-for-script-test
branch
from
c3d3fe1 to
da1c21a
Compare
pix-service-auto-merge
deleted the
pix-15633-use-deterministic-data-for-script-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Dans notre test du script get-elements pour extraire en CSV, on consomme le vrai didacticiel. Ainsi si le contenu est modifié, les tests de script peuvent casser.
🎁 Proposition
On préfère rendre le test déterministe et donc ne plus consommer le didacticiel.
🧦 Remarques
RAS
🎅 Pour tester
Commenter aléatoirement des lignes de https://github.com/1024pix/pix/blob/91aa62b353aa3175db12391948d9aa3052f9397b/api/scripts/modulix/get-elements-csv.js et constater que le test échoue.