[BUGFIX] ♻️ remaniement de la vérification des valeurs contenues dans le fichier CSV d'import de session en masse (PIX-15719) #10815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yaf
changed the title
yaf
force-pushed
the
refactor-csv-import-header-and-value-check
branch
from
18a4bc4 to
30aafe3
Compare
HEYGUL
reviewed
Dec 17, 2024
api/src/shared/infrastructure/serializers/csv/csv-serializer.js
Outdated
Show resolved
Hide resolved
yaf
force-pushed
the
refactor-csv-import-header-and-value-check
branch
from
30aafe3 to
045d85a
Compare
HEYGUL
approved these changes
Dec 18, 2024
alexandrecoin
added
Func Review OK
alexandrecoin
force-pushed
the
refactor-csv-import-header-and-value-check
branch
from
045d85a to
9da96c2
Compare
alexandrecoin
approved these changes
Dec 18, 2024
alexandrecoin
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
refactor-csv-import-header-and-value-check
branch
from
9da96c2 to
61e2828
Compare
https://1024pix.atlassian.net/wiki/spaces/DC/blog/edit-v2/4806377475 Strange value seems to pass through papa Csv parse (?). To prevent undefined value, we improve code around this. Co-authored-by: Alexandre Coin <[email protected]>
Co-Authored-By: GUL <[email protected]>
pix-service-auto-merge
force-pushed
the
refactor-csv-import-header-and-value-check
branch
from
61e2828 to
fe7b350
Compare
pix-service-auto-merge
deleted the
refactor-csv-import-header-and-value-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Nous nous sommes retrouvés avec une valeur
undefinedà un endroit inattendu lors d'un import de session en masse (voir https://1024pix.atlassian.net/wiki/spaces/DC/blog/2024/12/13/4806377475/Erreur+500+sur+l+import+en+masse+de+session).🎁 Proposition
Vérifier l'ensemble des valeurs du fichier pour lever une erreur s'il y en a une en
undefined.Ça ne devrait pas arriver.
🧦 Remarques
🎅 Pour tester
Impossible de reproduire l'erreur. Cependant, il serait bien de tester que l'import de session en masse continue de fonctionner.