Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Effacer le message d'erreur de saisie de l'externalId lors de la modification du précedent en erreur (PIX-15158) #10811

Merged

Conversation

xav-car
Copy link
Contributor

@xav-car xav-car commented Dec 13, 2024

🎄 Problème

en éditant le participantExternalId, on garde le message d'erreur affiché ce qui peut donner lieu à des incompréhension

🎁 Proposition

Cacher ce message d'erreur lorsque la saisie est modifié

🧦 Remarques

Ajout de seeds pour PROASSMUL avec un type EMAIL en participantExternalId

🎅 Pour tester

PixApp => [email protected]

Utiliser cette magnifique URL

https://app-pr10811.review.pix.fr/campagnes/PROASSMUL?participantExternalId=toto

Mauvais adresse email en paramètre => message d'erreur
Modification de la saisie => l'erreur s'évanouie 🪄

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car force-pushed the pix-15158/hide-error-message-new-value-externalId branch from e6a07b9 to a64bff5 Compare December 13, 2024 14:32
@xav-car xav-car marked this pull request as ready for review December 13, 2024 14:33
@xav-car xav-car force-pushed the pix-15158/hide-error-message-new-value-externalId branch 2 times, most recently from 10d6100 to dd1f5f8 Compare December 13, 2024 15:08
@alicegoarnisson alicegoarnisson added Func Review OK PO validated functionally the PR and removed 👀 Func Review Needed labels Dec 16, 2024
Copy link
Member

@lionelB lionelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question est ce qu'il ne faudrait pas rajouter les test supprimés sur la

  • envoi du formulaire
  • participant externalId > 255 char ou vide
  • bouton cancel

@xav-car xav-car force-pushed the pix-15158/hide-error-message-new-value-externalId branch from dd1f5f8 to aaf5248 Compare December 17, 2024 09:14
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-15158/hide-error-message-new-value-externalId branch from aaf5248 to 2c35426 Compare December 17, 2024 09:17
@lionelB lionelB force-pushed the pix-15158/hide-error-message-new-value-externalId branch from 2c35426 to 5048988 Compare December 17, 2024 10:48
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-15158/hide-error-message-new-value-externalId branch from 5048988 to f5a5048 Compare December 17, 2024 10:53
@pix-service-auto-merge pix-service-auto-merge merged commit cd43494 into dev Dec 17, 2024
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-15158/hide-error-message-new-value-externalId branch December 17, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants