Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUMP] Update dependency @1024pix/pix-ui to v51 (certif) #10783

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[BUMP] Update dependency @1024pix/pix-ui to v51 (certif) #10783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24550d7
[BUMP] Update dependency @1024pix/pix-ui to v51 (certif)
renovate[bot] Dec 11, 2024
62973ad
feat(certif): Change SCO PixBanner to PixNotification
AndreiaPena Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions certif/app/components/layout/banners.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import PixBannerAlert from '@1024pix/pix-ui/components/pix-banner-alert';
import PixNotificationAlert from '@1024pix/pix-ui/components/pix-notification-alert';
import { action } from '@ember/object';
import { service } from '@ember/service';
import Component from '@glimmer/component';
Expand Down Expand Up @@ -36,9 +37,9 @@ export default class Banners extends Component {

<template>
{{#if this.shouldDisplaySCOInformationBanner}}
<PixBannerAlert @canCloseBanner='true' class='banners'>
<PixNotificationAlert @type='information' @withIcon={{true}} class='banners'>
{{t 'pages.sco.banner.information' htmlSafe=true}}
</PixBannerAlert>
</PixNotificationAlert>
{{/if}}

{{#if this.shouldDisplayLocaleNotSupportedBanner}}
Expand Down
8 changes: 4 additions & 4 deletions certif/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion certif/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@1024pix/ember-api-actions": "^1.1.0",
"@1024pix/ember-testing-library": "^3.0.6",
"@1024pix/eslint-config": "^1.3.8",
"@1024pix/pix-ui": "^49.2.1",
"@1024pix/pix-ui": "^51.1.0",
"@1024pix/stylelint-config": "^5.1.24",
"@babel/eslint-parser": "^7.22.15",
"@babel/plugin-proposal-decorators": "^7.22.15",
Expand Down
20 changes: 18 additions & 2 deletions certif/tests/integration/components/layout/banners_test.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,15 @@ module('Integration | Component | Layout | Banners', function (hooks) {
const screen = await render(<template><Banners /></template>);

// then
assert.dom(screen.queryByRole('alert')).exists();
assert
.dom(
screen.getByText(
(content) =>
content.startsWith('La Certification Pix se déroulera du 7 novembre 2024 au 7 mars 2025 ') &&
content.endsWith('Collèges : du 17 mars au 13 juin 2025.'),
),
)
.exists();
});
});

Expand Down Expand Up @@ -185,7 +193,15 @@ module('Integration | Component | Layout | Banners', function (hooks) {
const screen = await render(<template><Banners /></template>);

// then
assert.dom(screen.queryByRole('alert')).doesNotExist();
assert
.dom(
screen.queryByText(
(content) =>
content.startsWith('La Certification Pix se déroulera du 7 novembre 2024 au 7 mars 2025 ') &&
content.endsWith('Collèges : du 17 mars au 13 juin 2025.'),
),
)
.doesNotExist();
});
});
});
Expand Down
Loading