[TECH] Migrer les participation avec un statut TO_SHARE et une date de participation (PIX-15647). #10773
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
approved these changes
Dec 10, 2024
VincentHardouin
changed the title
VincentHardouin
approved these changes
Dec 11, 2024
| await migrationToTest(knex); | ||
|
|
||
| // then | ||
| const patchedCampaign = await knex('campaign-participations').where('id', sharedParticipation.id).first(); |
There was a problem hiding this comment.
nitpick: renommer en notPatchedCampaign ? Vu qu'on est pas censé avoir mis a jour celle ci ?
lionelB
force-pushed
the
pix-15647/migrate-shared-at-participation
branch
from
acfbbfa to
1241348
Compare
lionelB
added
Tech Review OK
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-15647/migrate-shared-at-participation
branch
from
1241348 to
909353d
Compare
pix-service-auto-merge
deleted the
pix-15647/migrate-shared-at-participation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Certaines participations sont dans un état impossible (une date de partage mais un status TO_SHARE) ce qui bloque l'utilisateur si il souhaite partager sa participation dans PixApp. On suspecte le fait que les usecase d'envoi de resultat et de Retenter soient lancé en parallèlle.
🎁 Proposition
On ajoute une migration pour réparer les données.
🧦 Remarques
Un premier fix sur mon pix à bloquer l'utilisation simultanée des 2 boutons.
On va modifier mon-pix pour permettre de partager ses résultats en se basant seulement sur le statut et non pas si la date existe.
Il faudrait enfin s'assurer coté back que si les 2 usecases sont appellés, la concurrence soit gérer (peut être avec l'utilisation de .forUpdate() au moment du select de la participation.)
🎅 Pour tester
Modifier une participation en la passant a TO_SHARE avec sharedAT
Lancer un migrate:down puis un migrate:up