-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Le scroll auto ne descend pas assez bas (PIX-15476) #10675
Merged
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dianeCdrPix
commented
Nov 28, 2024
yannbertrand
reviewed
Dec 2, 2024
yannbertrand
reviewed
Dec 2, 2024
yannbertrand
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK avec le concept 👍
yannbertrand
changed the title
[FEATURE] Solution Alternative - Le scroll auto ne descend pas assez bas (PIX-15476)
[BUGFIX] Le scroll auto ne descend pas assez bas (PIX-15476)
Dec 2, 2024
clemlatz
force-pushed
the
PIX-15476-alternative-solution
branch
2 times, most recently
from
December 2, 2024 16:21
2924c74
to
1cc4632
Compare
yannbertrand
force-pushed
the
PIX-15476-alternative-solution
branch
from
December 3, 2024 13:24
1cc4632
to
02f3ed3
Compare
dianeCdrPix
force-pushed
the
PIX-15476-alternative-solution
branch
from
December 4, 2024 09:02
02f3ed3
to
0fe58d4
Compare
yannbertrand
force-pushed
the
PIX-15476-alternative-solution
branch
from
December 4, 2024 09:45
0fe58d4
to
5bcd53f
Compare
pix-service-auto-merge
force-pushed
the
PIX-15476-alternative-solution
branch
from
December 4, 2024 09:51
5bcd53f
to
a71644a
Compare
Co-authored-by: Clément Latzarus <[email protected]>
Co-authored-by: Clément Latzarus <[email protected]>
pix-service-auto-merge
force-pushed
the
PIX-15476-alternative-solution
branch
from
December 4, 2024 10:25
a71644a
to
a669b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
La barre de navigation n’est pas prise en compte dans le calcul du scroll, il faudrait inclure sa hauteur pour éviter de tomber au milieu d’un texte
🌰 Proposition
Utiliser un document.getelementById pour récupérer l'élément Navbar, le passer à la fonction focusAndScroll() et calculer la hauteur à laquelle afficher l'écran en fonction de l'épaisseur de la Navbar.
🎃 Remarques
🪵 Pour tester