-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Supprimer les learners précédent l'ajout de l'import à format (Pix-15428) #10661
Merged
pix-service-auto-merge
merged 8 commits into
dev
from
pix-15428/delete-learners-when-activate-feature
Dec 4, 2024
Merged
[FEATURE] Supprimer les learners précédent l'ajout de l'import à format (Pix-15428) #10661
pix-service-auto-merge
merged 8 commits into
dev
from
pix-15428/delete-learners-when-activate-feature
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
2 times, most recently
from
November 28, 2024 09:40
44f213d
to
6793907
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Nov 28, 2024
api/src/organizational-entities/domain/usecases/add-organization-feature-in-batch.js
Outdated
Show resolved
Hide resolved
api/src/organizational-entities/application/organization/organization.admin.controller.js
Show resolved
Hide resolved
...ption/learner-management/domain/usecases/find-organization-learners-before-import-feature.js
Outdated
Show resolved
Hide resolved
...ner-management/unit/domain/usecases/find-organization-learners-before-import-feature_test.js
Outdated
Show resolved
Hide resolved
api/src/prescription/learner-management/application/api/learners-api.js
Outdated
Show resolved
Hide resolved
api/src/prescription/learner-management/application/api/learners-api.js
Outdated
Show resolved
Hide resolved
api/src/prescription/learner-management/application/api/learners-api.js
Outdated
Show resolved
Hide resolved
api/tests/prescription/learner-management/unit/application/api/learners-api_test.js
Outdated
Show resolved
Hide resolved
xav-car
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
2 times, most recently
from
November 29, 2024 09:18
bef2ae8
to
b0027f9
Compare
machestla
reviewed
Nov 29, 2024
...escription/learner-management/infrastructure/repositories/organization-learner-repository.js
Outdated
Show resolved
Hide resolved
xav-car
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
from
November 29, 2024 09:24
b0027f9
to
c6b770e
Compare
machestla
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tech review ok ✅ 🐕
machestla
added
Func Review OK
PO validated functionally the PR
and removed
👀 Func Review Needed
labels
Nov 29, 2024
func review ok ✅ 🐕 🦖 🦦 |
xav-car
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
3 times, most recently
from
December 2, 2024 09:14
41fe95b
to
614d0ea
Compare
lionelB
reviewed
Dec 2, 2024
api/src/organizational-entities/infrastructure/repositories/organization-feature-repository.js
Show resolved
Hide resolved
lionelB
reviewed
Dec 2, 2024
...escription/learner-management/infrastructure/repositories/organization-learner-repository.js
Show resolved
Hide resolved
lionelB
reviewed
Dec 2, 2024
api/src/organizational-entities/domain/usecases/add-organization-feature-in-batch.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Dec 2, 2024
lionelB
reviewed
Dec 2, 2024
api/src/organizational-entities/infrastructure/repositories/organization-feature-repository.js
Show resolved
Hide resolved
lionelB
approved these changes
Dec 2, 2024
xav-car
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
2 times, most recently
from
December 2, 2024 14:20
0abee17
to
56491ab
Compare
pix-service-auto-merge
force-pushed
the
pix-15428/delete-learners-when-activate-feature
branch
from
December 4, 2024 09:44
56491ab
to
93c2cc9
Compare
pix-service-auto-merge
deleted the
pix-15428/delete-learners-when-activate-feature
branch
December 4, 2024 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
team-acces
team-prescription
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Une organisation ayant vécu une vie paisible avant l'import à format se retrouve avec des apprenants qu'il est impossible de réconcilier après l'ajout de la feature.
Lors du premier import cela a pour effet de désactiver les anciens ( jusque là tout va bien), mais il sera impossible a des utilisateurs réconcilier des utilisateurs qui ont un apprenant désactivé dans cette organisation.
🌰 Proposition
Lors de l'ajout de l'import à format, il faudrait supprimer les apprenants antérieur à l'ajout de la feature d'import. cela aura pour effet de supprimer automatiquement les apprenants ainsi que leur participation. Pour revenir dans un état d'apprenant inexistant. Afin que l'import et la réconciliation se passe dans les meilleurs conditions pour todo el mundo.
🎃 Remarques
RAS
🪵 Pour tester
Ajouter l'import à format sur une organization ayant déjà des apprenants. Vérifier que les anciens sont supprimés. voili voilou