-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Migrer la mise à jour d'un profile cible dans son bounded context (PIX-15243) #10510
Conversation
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
128be21
to
64b3cf6
Compare
Func review ok ✅ |
@@ -1,4 +1,4 @@ | |||
import { DomainTransaction } from '../DomainTransaction.js'; | |||
import { DomainTransaction } from '../../../../../lib/infrastructure/DomainTransaction.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion : importer les DomainTransaction
se trouvant dans shared
import * as targetProfileSummaryForAdminRepository from '../../infrastructure/repositories/target-profile-summary-for-admin-repository.js'; | ||
|
||
/** | ||
* @typedef {import('../../infrastructure/repositories/')} AdminMemberRepository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech review ok en mob ✅
64b3cf6
to
17ba50f
Compare
🍂 Problème
< 💯
🌰 Proposition
go to 💯
🎃 Remarques
RAS
🪵 Pour tester
CI au vert
Permettre la modification d'un profil cible sur PixAdmin