Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Migrer la mise à jour d'un profile cible dans son bounded context (PIX-15243) #10510

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

xav-car
Copy link
Contributor

@xav-car xav-car commented Nov 7, 2024

🍂 Problème

< 💯

🌰 Proposition

go to 💯

🎃 Remarques

RAS

🪵 Pour tester

CI au vert
Permettre la modification d'un profil cible sur PixAdmin

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car changed the title [TECH] Migrer la mise à jour d'un profile cible dans son bounded context (PIX-XXXXX) [TECH] Migrer la mise à jour d'un profile cible dans son bounded context (PIX-15243) Nov 7, 2024
@xav-car xav-car force-pushed the migrate-update-taget-profile branch 2 times, most recently from 128be21 to 64b3cf6 Compare November 7, 2024 15:11
@xav-car xav-car marked this pull request as ready for review November 7, 2024 15:16
@xav-car xav-car requested a review from a team as a code owner November 7, 2024 15:16
@machestla machestla added Func Review OK PO validated functionally the PR and removed 👀 Func Review Needed labels Nov 8, 2024
@machestla
Copy link
Contributor

Func review ok ✅

@@ -1,4 +1,4 @@
import { DomainTransaction } from '../DomainTransaction.js';
import { DomainTransaction } from '../../../../../lib/infrastructure/DomainTransaction.js';
Copy link
Contributor

@machestla machestla Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion : importer les DomainTransaction se trouvant dans shared

import * as targetProfileSummaryForAdminRepository from '../../infrastructure/repositories/target-profile-summary-for-admin-repository.js';

/**
* @typedef {import('../../infrastructure/repositories/')} AdminMemberRepository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨

Copy link
Contributor

@machestla machestla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech review ok en mob ✅

@pix-service-auto-merge pix-service-auto-merge force-pushed the migrate-update-taget-profile branch from 64b3cf6 to 17ba50f Compare November 8, 2024 10:01
@pix-service-auto-merge pix-service-auto-merge merged commit 986812c into dev Nov 8, 2024
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the migrate-update-taget-profile branch November 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants