-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Ajouter des paramètres dans l'URL du lien custom de fin de parcours (PIX-15184). #10505
Merged
pix-service-auto-merge
merged 1 commit into
dev
from
pix-15184-custom-organization-results-block-link-should-accept-params
Nov 7, 2024
Merged
[BUGFIX] Ajouter des paramètres dans l'URL du lien custom de fin de parcours (PIX-15184). #10505
pix-service-auto-merge
merged 1 commit into
dev
from
pix-15184-custom-organization-results-block-link-should-accept-params
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
PR relatives à l'expérience d'évaluation
labels
Nov 6, 2024
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-15184-custom-organization-results-block-link-should-accept-params
branch
2 times, most recently
from
November 6, 2024 17:43
a4db38a
to
f4d3f07
Compare
La-toile-cosmique
approved these changes
Nov 7, 2024
...omponents/campaigns/assessment/results/evaluation-results-hero/custom-organization-block.gjs
Outdated
Show resolved
Hide resolved
xav-car
previously approved these changes
Nov 7, 2024
xav-car
dismissed
their stale review
November 7, 2024 10:26
Suite à une seconde func, on a vu qu'il manquait un petit parseInt
Jeyffrey
force-pushed
the
pix-15184-custom-organization-results-block-link-should-accept-params
branch
from
November 7, 2024 10:57
f4d3f07
to
5c35847
Compare
C'est modifié |
xav-car
approved these changes
Nov 7, 2024
xav-car
changed the title
[FEATURE] Ajouter des paramètres dans l'URL du lien custom de fin de parcours (PIX-15184).
[BUGFIX] Ajouter des paramètres dans l'URL du lien custom de fin de parcours (PIX-15184).
Nov 7, 2024
xav-car
added
Tech Review OK
Func Review OK
PO validated functionally the PR
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Nov 7, 2024
pix-service-auto-merge
force-pushed
the
pix-15184-custom-organization-results-block-link-should-accept-params
branch
from
November 7, 2024 13:02
5c35847
to
c063a3a
Compare
pix-service-auto-merge
deleted the
pix-15184-custom-organization-results-block-link-should-accept-params
branch
November 7, 2024 13:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
team-evaluation
PR relatives à l'expérience d'évaluation
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Lors de la création de la nouvelle page de fin de parcours, l'intégration de search params dans le lien custom de fin de parcours a été oublié.
🌰 Proposition
Permettre l'ajout de 3 paramètres dans l'URL custom de fin de parcours (stage, masteryRate, externalId).
🎃 Remarques
Ce code existait ici :
pix/mon-pix/app/components/routes/campaigns/assessment/skill-review.js
Line 151 in c582ae4
🪵 Pour tester
[email protected]