[FEATURE] Ajuster le wording et le design des pages d'authentification (PIX-15198) #10502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
EmmanuelleBonnemay
force-pushed
the
pix-15198-improve-authentication-pages-wording-and-design
branch
from
de4c866 to
30a3b33
Compare
bpetetot
reviewed
Nov 7, 2024
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
Mettre la même marge entre le bouton et le texte que pour la page des SSO:
There was a problem hiding this comment.
Modification faite !
er-lim
approved these changes
Nov 7, 2024
| @@ -115,15 +114,11 @@ export default class PasswordResetDemandForm extends Component { | |||
| </div> | |||
|
|
|||
| <p class="authentication-password-reset-demand-form__help"> | |||
There was a problem hiding this comment.
Suggestion utiliser plutôt une balise section qui me paraît plus approprié pour ce bloc 😄
Suggested change
| <p class="authentication-password-reset-demand-form__help"> | |
| <section class="authentication-password-reset-demand-form__help"> |
There was a problem hiding this comment.
Modification faite, merci !
J'ai aussi ajouté un white-space: normal qui règle le cas des noms très longs. (j'ai trouvé le nowrap mais pas le wrap !)
EmmanuelleBonnemay
force-pushed
the
pix-15198-improve-authentication-pages-wording-and-design
branch
2 times, most recently
from
8ca2baa to
f0629fa
Compare
EmmanuelleBonnemay
added
Tech Review OK
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-15198-improve-authentication-pages-wording-and-design
branch
from
f0629fa to
6c89f16
Compare
pix-service-auto-merge
deleted the
pix-15198-improve-authentication-pages-wording-and-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Il faut traiter les retours de la recette des nouvelles pages d'authentification
🌰 Proposition
Traiter les points soulevés dans https://1024pix.atlassian.net/wiki/spaces/DA/pages/4647419930/Recette+des+mires+de+connexion#Phase-de-recette-2
e.g [email protected]🎃 Remarques
Les clés de traduction mériteront peut-être d'être triées / réorganisées dans un autre ticket.
🪵 Pour tester
Vérifier les points évoqués dans https://1024pix.atlassian.net/wiki/spaces/DA/pages/4647419930/Recette+des+mires+de+connexion#Phase-de-recette-2