[DOC] ADR-57 - Migration des fichiers SCSS dans le dossier des composants #10481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
lionelB
approved these changes
Nov 5, 2024
yannbertrand
approved these changes
Nov 6, 2024
| - Pour un composant donné, les styles sont plus faciles à retrouver et à maintenir | ||
|
|
||
| ### Inconvénients | ||
| - On est hors du paradigme d’Ember, risque de problèmes futurs inattendus |
There was a problem hiding this comment.
Ça n'a pas encore l'air sec sec mais ils évoquent d'autres approches (<style> blocks for scoped CSS) et questionnement notamment le lien avec le reste de l'écosystème : CSS Modules, Emotion, Styled Components, vanilla-extract...
La RFC est en statut "Ready For Release" alors j'imagine qu'il faut rester attentif sur les prochaines communications.
mcampourcy
force-pushed
the
adr-057-css-files-close-to-component-files
branch
from
6308cf6 to
056180a
Compare
xav-car
approved these changes
Nov 8, 2024
mcampourcy
force-pushed
the
adr-057-css-files-close-to-component-files
branch
from
056180a to
07a8eb7
Compare
lionelB
added
team-acces
team-certif
team-evaluation
HEYGUL
reviewed
Dec 4, 2024
HEYGUL
reviewed
Dec 4, 2024
HEYGUL
approved these changes
Dec 4, 2024
mcampourcy
force-pushed
the
adr-057-css-files-close-to-component-files
branch
from
07a8eb7 to
0825995
Compare
mcampourcy
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
adr-057-css-files-close-to-component-files
branch
from
0825995 to
e220b25
Compare
pix-service-auto-merge
deleted the
adr-057-css-files-close-to-component-files
branch
HEYGUL
pushed a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Le paradigme d’Ember impose de séparer tous les fichiers (controllers, templates, styles) en gardant la même arborescence pour s’y retrouver. Dans le cas des styles, ça peut être franchement laborieux de s'y retrouver.
🌰 Proposition
Création d'une ADR proposant de mettre les fichiers de style dans le dossier des composants.
🎃 Remarques
RAS
🪵 Pour tester