-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Bloquer la finalisation de session selon certaines conditions sur Pix Certif (PIX-14717). #10473
[FEATURE] Bloquer la finalisation de session selon certaines conditions sur Pix Certif (PIX-14717). #10473
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,27 +121,29 @@ | |
</div> | ||
|
||
<div class="session-details-buttons"> | ||
<PixButtonLink | ||
@route="authenticated.sessions.update" | ||
@model={{this.session.id}} | ||
aria-label={{t "pages.sessions.detail.parameters.actions.update" sessionId=this.session.id}} | ||
> | ||
{{t "common.actions.update"}} | ||
</PixButtonLink> | ||
{{#if this.sessionHasStarted}} | ||
<PixButtonLink @route="authenticated.sessions.update" @model={{this.session.id}}> | ||
{{t "common.actions.update"}} | ||
</PixButtonLink> | ||
{{#if this.sessionManagement.isFinalized}} | ||
{{#if this.isSessionFinalizationTemporarilyBlocked}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cette suite d'imbrications et d'enchainements logiques au niveau templating me fait dire que l'on devrait aller vers de la separation de composants / refacto des conditions |
||
<p class="session-details-row__session-finalized-warning"> | ||
{{t "pages.sessions.detail.parameters.finalization-info"}} | ||
{{t "pages.sessions.detail.parameters.finalization.temporarily-blocked"}} | ||
</p> | ||
{{else}} | ||
<PixButtonLink @route="authenticated.sessions.finalize" @model={{this.session.id}} class="push-right"> | ||
{{t "pages.sessions.detail.parameters.actions.finalizing"}} | ||
</PixButtonLink> | ||
{{#if this.sessionManagement.isFinalized}} | ||
<p class="session-details-row__session-finalized-warning"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Les differentes |
||
{{t "pages.sessions.detail.parameters.finalization-info"}} | ||
</p> | ||
{{else}} | ||
<PixButtonLink @route="authenticated.sessions.finalize" @model={{this.session.id}} class="push-right"> | ||
{{t "pages.sessions.detail.parameters.actions.finalizing"}} | ||
</PixButtonLink> | ||
{{/if}} | ||
{{/if}} | ||
{{else}} | ||
<PixButtonLink | ||
@route="authenticated.sessions.update" | ||
@model={{this.session.id}} | ||
aria-label={{t "pages.sessions.detail.parameters.actions.update" sessionId=this.session.id}} | ||
> | ||
{{t "common.actions.update"}} | ||
</PixButtonLink> | ||
{{/if}} | ||
</div> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposition de simplification