Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Afficher les flashcards à plat dans la preview (PIX-14316) #10412

Merged

Conversation

er-lim
Copy link
Contributor

@er-lim er-lim commented Oct 25, 2024

🦄 Problème

Actuellement, il n'y a que la carte d'introduction qui s'affiche en mode preview ce qui empêche de vérifier l'affichage de toutes les cartes.

🤖 Proposition

  • Afficher toutes les flashcards (introduction, recto, verso et conclusion) en preview

🌈 Remarques

💯 Pour tester

  • Aller sur /modules/preview
  • Modifier le json par celui du didacticiel modulix
  • Vérifier que toutes les flashcards s'affiche bien 🎉

@er-lim er-lim requested review from a team as code owners October 25, 2024 13:45
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@clemlatz clemlatz force-pushed the pix-14316-display-all-flashcards-in-preview branch from 5a16195 to 7386fd6 Compare October 25, 2024 14:32
@clemlatz clemlatz force-pushed the pix-14316-display-all-flashcards-in-preview branch from 7386fd6 to b28fcde Compare October 25, 2024 15:01
Comment on lines +136 to +128
<div class="element-flashcards__recto-verso">
<ModulixFlashcardsCard @card={{card}} @displayedSideName="recto" @onCardFlip={{this.noop}} />
<ModulixFlashcardsCard @card={{card}} @displayedSideName="verso" @onCardFlip={{this.noop}} />
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-14316-display-all-flashcards-in-preview branch from de3dcd4 to 6af7f5f Compare October 28, 2024 10:46
@pix-service-auto-merge pix-service-auto-merge merged commit 3fce584 into dev Oct 28, 2024
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-14316-display-all-flashcards-in-preview branch October 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants