[TECH] Améliorer le mot de passe surveillant (PIX-13007). #10154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Steph0
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
4f89e6e to
44a1ae2
Compare
AndreiaPena
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
44a1ae2 to
41ddfdf
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13912190 | Triggered | Generic Password | 52a78ef | api/src/certification/enrolment/domain/models/SessionEnrolment.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
P-Jeremy
previously requested changes
Sep 20, 2024
There was a problem hiding this comment.
Si je vous dis que j'adore bosser avec vous et en particulier @AndreiaPena , c'est utile ou inutile ? ❤️
AndreiaPena
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
AndreiaPena
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
41ddfdf to
42dc7fd
Compare
matthieu-octo
approved these changes
Sep 23, 2024
alexandrecoin
approved these changes
Sep 23, 2024
HEYGUL
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
42dc7fd to
ec64237
Compare
Steph0
reviewed
Sep 25, 2024
api/src/certification/enrolment/domain/models/SessionEnrolment.js
Outdated
Show resolved
Hide resolved
matthieu-octo
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
ec64237 to
2f6348b
Compare
Steph0
approved these changes
Sep 25, 2024
api/tests/certification/enrolment/acceptance/application/session-mass-import-route_test.js
Show resolved
Hide resolved
api/tests/certification/enrolment/unit/domain/models/SessionEnrolment_test.js
Outdated
Show resolved
Hide resolved
| `${config.availableCharacterForCode.numbers}${config.availableCharacterForCode.letters}`.split(''); | ||
| const NB_CHAR = 5; | ||
| const INVIGILATOR_PASSWORD_LENGTH = 6; | ||
| const INVIGILATOR_PASSWORD_CHARS = '23456789bcdfghjkmpqrstvwxyBCDFGHJKMPQRSTVWXY!*?'.split(''); |
|
Re-test, et j'ai obtenu un caractere special
|
Steph0
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
2f6348b to
e607097
Compare
Steph0
added
Tech Review OK
Func Review OK
* naming changed * varchar length changed to 6 * seeds Co-authored-by: Andreia Pena <[email protected]> Co-authored-by: matthieu-octo <[email protected]> Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
Co-authored-by: Steph0 <[email protected]> Co-authored-by: matthieu-octo <[email protected]>
Co-authored-by: Steph0 <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-13007-improve-invigilator-password-security
branch
from
e607097 to
52a78ef
Compare
pix-service-auto-merge
deleted the
pix-13007-improve-invigilator-password-security
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement le mot de passe surveillant n'est pas assez fort.
🤖 Proposition
Renforcer le mot de passe
🌈 Remarques
On profite de cette PR pour renommer la colonne SupervisorPassword en invigilatorPassword.
💯 Pour tester
Constater que certif récupère bien le mot de passe surveillant
=> Détails de la session
=> Kit surveillant
=> Que l'utilisateur puisse bien se connecter dans l'espace surveillant