[FEATURE] Ajouter le profileRewardId dans le endpoint qui remonte les…

… résultats d'une quête (PIX-15322) #10565
1024pix · Nov 18, 2024 · c8c91a0 · c8c91a0
2 parents 90b65ac + 279edff
commit c8c91a0
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 3 deletions.
diff --git a/api/src/quest/domain/models/QuestResult.js b/api/src/quest/domain/models/QuestResult.js
@@ -1,7 +1,8 @@
 export class QuestResult {
-  constructor({ id, obtained, reward }) {
+  constructor({ id, obtained, reward, profileRewardId }) {
     this.id = id;
     this.obtained = obtained;
+    this.profileRewardId = profileRewardId;
     this.reward = reward;
   }
 }
diff --git a/api/src/quest/infrastructure/repositories/reward-repository.js b/api/src/quest/infrastructure/repositories/reward-repository.js
@@ -26,6 +26,7 @@ export const getByQuestAndUserId = async ({
     return new QuestResult({
       id: quest.id,
       obtained: true,
+      profileRewardId: profileRewardForQuest.id,
       reward,
     });
   }
@@ -41,6 +42,7 @@ export const getByQuestAndUserId = async ({
   return new QuestResult({
     id: quest.id,
     obtained,
+    profileRewardId: null,
     reward,
   });
 };
diff --git a/api/src/quest/infrastructure/serializers/quest-result-serializer.js b/api/src/quest/infrastructure/serializers/quest-result-serializer.js
@@ -4,7 +4,7 @@ const { Serializer } = jsonapiSerializer;
 
 const serialize = function (questResult) {
   return new Serializer('quest-result', {
-    attributes: ['obtained', 'reward'],
+    attributes: ['obtained', 'reward', 'profileRewardId'],
   }).serialize(questResult);
 };
 

diff --git a/api/src/shared/config.js b/api/src/shared/config.js
@@ -416,6 +416,8 @@ const configuration = (function () {
     config.featureToggles.isPix1dEnabled = true;
     config.featureToggles.isPixCompanionEnabled = false;
     config.featureToggles.isSelfAccountDeletionEnabled = false;
+    config.featureToggles.isQuestEnabled = false;
+    config.featureToggles.isAsyncQuestRewardingCalculationEnabled = false;
     config.featureToggles.isTextToSpeechButtonEnabled = false;
     config.featureToggles.showNewResultPage = false;
     config.featureToggles.showExperimentalMissions = false;

diff --git a/api/tests/quest/unit/infrastructure/repositories/reward-repository_test.js b/api/tests/quest/unit/infrastructure/repositories/reward-repository_test.js
@@ -36,7 +36,7 @@ describe('Quest | Unit | Infrastructure | Repositories | Reward', function () {
 
     it('should return QuestResult with obtained true when reward is obtained', async function () {
       // given
-      const profileReward = [{ rewardId: quest.rewardId, rewardType: quest.rewardType }];
+      const profileReward = [{ rewardId: quest.rewardId, rewardType: quest.rewardType, profileRewardId: 1 }];
       profileRewardApiStub.getByUserId.withArgs(userId).resolves(profileReward);
 
       // when
@@ -51,6 +51,7 @@ describe('Quest | Unit | Infrastructure | Repositories | Reward', function () {
       // then
       expect(result).to.be.an.instanceof(QuestResult);
       expect(result.id).to.equal(quest.id);
+      expect(result.profileRewardId).to.equal(profileReward.profileRewardId);
       expect(result.reward).to.equal(reward);
       expect(result.obtained).to.be.true;
     });
@@ -75,6 +76,7 @@ describe('Quest | Unit | Infrastructure | Repositories | Reward', function () {
       expect(result).to.be.an.instanceof(QuestResult);
       expect(result.id).to.equal(quest.id);
       expect(result.reward).to.equal(reward);
+      expect(result.profileRewardId).to.be.null;
       expect(result.obtained).to.be.false;
     });
 
@@ -98,6 +100,7 @@ describe('Quest | Unit | Infrastructure | Repositories | Reward', function () {
       expect(result).to.be.an.instanceof(QuestResult);
       expect(result.id).to.equal(quest.id);
       expect(result.reward).to.equal(reward);
+      expect(result.profileRewardId).to.be.null;
       expect(result.obtained).to.be.null;
     });
   });

diff --git a/api/tests/quest/unit/infrastructure/serializers/quest-result-serializer_test.js b/api/tests/quest/unit/infrastructure/serializers/quest-result-serializer_test.js
@@ -10,6 +10,7 @@ describe('Quest | Unit | Infrastructure | Serializers | quest-result', function
       id: 1,
       obtained: true,
       reward: new Attestation({ id: 10, key: 'MY_KEY', templateName: 'my-key', createdAt: new Date('2020-10-10') }),
+      profileRewardId: 1,
     });
 
     // when
@@ -23,6 +24,7 @@ describe('Quest | Unit | Infrastructure | Serializers | quest-result', function
         attributes: {
           obtained: true,
           reward: { id: 10, templateName: 'my-key', key: 'MY_KEY', createdAt: new Date('2020-10-10') },
+          'profile-reward-id': 1,
         },
       },
     });