Skip to content

Commit

Permalink
[TECH] Remplacer la lib eslint-plugin-local-rules par `@1024pix/esl…
Browse files Browse the repository at this point in the history
…int-plugin`
  • Loading branch information
pix-service-auto-merge authored Oct 17, 2023
2 parents c26d121 + 421b44b commit 5f9cc91
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 29 deletions.
3 changes: 1 addition & 2 deletions api/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
globals: {
include: true,
},
plugins: ['knex', 'unicorn', 'local-rules'],
plugins: ['knex', 'unicorn'],
rules: {
'no-console': 'error',
'mocha/no-hooks-for-single-case': 'off',
Expand Down Expand Up @@ -67,6 +67,5 @@ module.exports = {
],
},
],
'local-rules/no-sinon-stub-with-args-oneliner': 'error',
},
};
7 changes: 0 additions & 7 deletions api/eslint-local-rules.cjs

This file was deleted.

26 changes: 10 additions & 16 deletions api/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@
"yargs": "^17.5.1"
},
"devDependencies": {
"@1024pix/eslint-config": "^1.0.3",
"@1024pix/eslint-plugin-no-sinon-stub-with-args-oneliner": "^0.2.0",
"@1024pix/eslint-config": "^1.1.0",
"@1024pix/eslint-plugin": "^1.0.0",
"@babel/eslint-parser": "^7.18.2",
"@babel/plugin-syntax-import-assertions": "^7.20.0",
"@ls-lint/ls-lint": "^2.0.0",
Expand All @@ -100,7 +100,6 @@
"eslint-plugin-i18n-json": "^4.0.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-knex": "https://github.com/1024pix/eslint-plugin-knex#master",
"eslint-plugin-local-rules": "^2.0.0",
"eslint-plugin-mocha": "^10.0.5",
"eslint-plugin-n": "^16.0.0",
"eslint-plugin-prettier": "^5.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('Unit | Scripts | organizations-by-external-id-helper.js', function ()
];

// TODO: Fix this the next time the file is edited.
// eslint-disable-next-line local-rules/no-sinon-stub-with-args-oneliner
// eslint-disable-next-line @1024pix/no-sinon-stub-with-args-oneliner
const findByExternalIdsFetchingIdsOnlyStub = sinon.stub().withArgs(['A100', 'B200']).resolves([]);
const organizationRepository = { findByExternalIdsFetchingIdsOnly: findByExternalIdsFetchingIdsOnlyStub };

Expand Down

0 comments on commit 5f9cc91

Please sign in to comment.