[BUGFIX] Ne pas retourner une erreur 500 lors de la vérification de l…

…'éligibilité d'un utilisateur sans badges (PIX-14764). #10378
1024pix · Oct 22, 2024 · 5b2b938 · 5b2b938
2 parents ed30727 + 5c317a4
commit 5b2b938
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/api/src/certification/enrolment/domain/usecases/verify-candidate-subscriptions.js b/api/src/certification/enrolment/domain/usecases/verify-candidate-subscriptions.js
@@ -59,7 +59,7 @@ export async function verifyCandidateSubscriptions({
       certificationBadgesService,
     });
 
-    if (_isSubscribedUserBadgeOutDated(subscribedHighestBadgeAcquisition)) {
+    if (!subscribedHighestBadgeAcquisition || _isSubscribedUserBadgeOutDated(subscribedHighestBadgeAcquisition)) {
       throw new CertificationCandidateEligibilityError();
     }
 

diff --git a/...tests/certification/enrolment/unit/domain/usecases/verify-candidate-subscriptions_test.js b/...tests/certification/enrolment/unit/domain/usecases/verify-candidate-subscriptions_test.js
@@ -254,6 +254,47 @@ describe('Certification | Enrolment | Unit | Domain | UseCase | verify-candidate
           expect(error).to.be.instanceOf(CertificationCandidateEligibilityError);
         });
       });
+
+      context('when there is no acquired badges', function () {
+        it('should throw CertificationCandidateEligibilityError', async function () {
+          // given
+          const certificationCandidateId = 456;
+          const complementaryCertificationId = 789;
+
+          const candidate = domainBuilder.certification.enrolment.buildCandidate({
+            id: certificationCandidateId,
+            userId: 1234,
+            subscriptions: [
+              domainBuilder.certification.enrolment.buildComplementarySubscription({
+                certificationCandidateId,
+                complementaryCertificationId,
+              }),
+            ],
+          });
+
+          dependencies.pixCertificationRepository.findByUserId.resolves([
+            domainBuilder.certification.enrolment.buildPixCertification({
+              pixScore: 250,
+              status: AssessmentResult.status.VALIDATED,
+              isCancelled: false,
+              isRejectedForFraud: false,
+            }),
+          ]);
+
+          dependencies.certificationBadgesService.findLatestBadgeAcquisitions.resolves([]);
+
+          // when
+          const error = await catchErr(verifyCandidateSubscriptions)({
+            userId: candidate.userId,
+            candidate,
+            limitDate: Date.now(),
+            ...dependencies,
+          });
+
+          //then
+          expect(error).to.be.instanceOf(CertificationCandidateEligibilityError);
+        });
+      });
       context('when score is below lower level', function () {
         it('should throw CertificationCandidateEligibilityError', async function () {
           // given