♻️ refactor: use shared Joi email validation instead of regexp

1024pix · Nov 28, 2024 · 492483b · 492483b
1 parent cd399f7
commit 492483b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 58 deletions.
diff --git a/api/lib/domain/services/email-validator.js b/api/lib/domain/services/email-validator.js
diff --git a/api/src/organizational-entities/domain/usecases/update-organizations-in-batch.usecase.js b/api/src/organizational-entities/domain/usecases/update-organizations-in-batch.usecase.js
@@ -1,7 +1,7 @@
 import { createReadStream } from 'node:fs';
 
-import { emailIsValid } from '../../../../lib/domain/services/email-validator.js';
 import { DomainTransaction } from '../../../shared/domain/DomainTransaction.js';
+import * as emailValidationService from '../../../shared/domain/services/email-validation-service.js';
 import { CsvColumn } from '../../../shared/infrastructure/serializers/csv/csv-column.js';
 import { CsvParser } from '../../../shared/infrastructure/serializers/csv/csv-parser.js';
 import { getDataBuffer } from '../../../shared/infrastructure/utils/buffer.js';
@@ -117,7 +117,7 @@ async function checkOrganizationUpdate(organizationBatchUpdateDto, organizationF
 
   if (
     organizationBatchUpdateDto.dataProtectionOfficerEmail &&
-    !emailIsValid(organizationBatchUpdateDto.dataProtectionOfficerEmail)
+    !emailValidationService.validateEmailSyntax(organizationBatchUpdateDto.dataProtectionOfficerEmail)
   ) {
     throw new DpoEmailInvalid({
       meta: {

diff --git a/api/tests/unit/domain/services/email-validator_test.js b/api/tests/unit/domain/services/email-validator_test.js