✨ api: do not display pro message when session version is 3

1024pix · Nov 14, 2024 · 4074cab · 4074cab
1 parent 8ed300a
commit 4074cab
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 2 deletions.
diff --git a/api/src/certification/results/infrastructure/utils/pdf/AttestationViewModel.js b/api/src/certification/results/infrastructure/utils/pdf/AttestationViewModel.js
@@ -5,6 +5,7 @@ const { sortBy } = lodash;
 import dayjs from 'dayjs';
 
 import { toArrayOfFixedLengthStringsConservingWords } from '../../../../../shared/infrastructure/utils/string-utils.js';
+import { SESSIONS_VERSIONS } from '../../../../shared/domain/models/SessionVersion.js';
 
 const PROFESSIONALIZING_VALIDITY_START_DATE = new Date('2022-01-01');
 
@@ -26,6 +27,7 @@ class AttestationViewModel {
     stickers,
     competenceDetailViewModels,
     isFrenchDomainExtension,
+    version,
   }) {
     this.pixScore = pixScore;
     this.maxReachableScore = maxReachableScore;
@@ -43,6 +45,7 @@ class AttestationViewModel {
     this._hasAcquiredAnyComplementaryCertifications = hasAcquiredAnyComplementaryCertifications;
     this.stickers = stickers;
     this._isFrenchDomainExtension = isFrenchDomainExtension;
+    this._version = version;
   }
 
   certificationDate({ lang }) {
@@ -58,9 +61,12 @@ class AttestationViewModel {
   }
 
   shouldDisplayProfessionalizingCertificationMessage() {
-    if (!this._isFrenchDomainExtension) return false;
     if (!this._deliveredAt) return false;
-    return this._deliveredAt.getTime() >= PROFESSIONALIZING_VALIDITY_START_DATE.getTime();
+    return (
+      this._isFrenchDomainExtension &&
+      this._deliveredAt.getTime() >= PROFESSIONALIZING_VALIDITY_START_DATE.getTime() &&
+      this._version === SESSIONS_VERSIONS.V2
+    );
   }
 
   static from({ certificate, isFrenchDomainExtension, translate, lang }) {
@@ -85,6 +91,7 @@ class AttestationViewModel {
     const birth = _formatDate({ date: certificate.birthdate, lang }) + birthplace;
     const certificationCenter = certificate.certificationCenter;
     const deliveredAt = certificate.deliveredAt;
+    const version = certificate.version;
 
     const maxReachableLevelOnCertificationDate = certificate.maxReachableLevelOnCertificationDate < 8;
     const hasAcquiredAnyComplementaryCertifications = certificate.hasAcquiredAnyComplementaryCertifications();
@@ -119,6 +126,7 @@ class AttestationViewModel {
       stickers,
       competenceDetailViewModels,
       isFrenchDomainExtension,
+      version,
     });
   }
 }

diff --git a/...ure/utils/pdf/certification-attestation-pdf-v3-without-professionalizing-message_test.pdf b/...ure/utils/pdf/certification-attestation-pdf-v3-without-professionalizing-message_test.pdf
diff --git a/...cation/results/integration/infrastructure/utils/pdf/certification-attestation-pdf_test.js b/...cation/results/integration/infrastructure/utils/pdf/certification-attestation-pdf_test.js
@@ -5,6 +5,7 @@ import dayjs from 'dayjs';
 import pdfLibUtils from 'pdf-lib/cjs/utils/index.js';
 
 import { getCertificationAttestationsPdfBuffer } from '../../../../../../../src/certification/results/infrastructure/utils/pdf/certification-attestation-pdf.js';
+import { SESSIONS_VERSIONS } from '../../../../../../../src/certification/shared/domain/models/SessionVersion.js';
 import { CertificationAttestationGenerationError } from '../../../../../../../src/shared/domain/errors.js';
 import { getI18n } from '../../../../../../../src/shared/infrastructure/i18n/i18n.js';
 import { catchErr, domainBuilder, expect, nock, sinon } from '../../../../../../test-helper.js';
@@ -162,6 +163,7 @@ describe('Integration | Infrastructure | Utils | Pdf | Certification Attestation
           },
         ],
         deliveredAt: deliveredBeforeStartDate,
+        version: SESSIONS_VERSIONS.V2,
       });
     const certificateWithComplementaryCertificationsAndWithProfessionalizingMessage =
       domainBuilder.buildCertificationAttestation({
@@ -180,6 +182,7 @@ describe('Integration | Infrastructure | Utils | Pdf | Certification Attestation
           },
         ],
         deliveredAt: deliveredAfterStartDate,
+        version: SESSIONS_VERSIONS.V2,
       });
     const certificateWithoutComplementaryCertificationsAndWithoutProfessionalizingMessage =
       domainBuilder.buildCertificationAttestation({
@@ -191,6 +194,7 @@ describe('Integration | Infrastructure | Utils | Pdf | Certification Attestation
         pixPlusDroitCertificationImagePath: null,
         certifiedBadges: [],
         deliveredAt: deliveredBeforeStartDate,
+        version: SESSIONS_VERSIONS.V2,
       });
     const certificateComplementaryCertificationsAndWithProfessionalizingMessage =
       domainBuilder.buildCertificationAttestation({
@@ -202,6 +206,7 @@ describe('Integration | Infrastructure | Utils | Pdf | Certification Attestation
         pixPlusDroitCertificationImagePath: null,
         certifiedBadges: [],
         deliveredAt: deliveredAfterStartDate,
+        version: SESSIONS_VERSIONS.V2,
       });
     const referencePdfPath = 'certification-attestation-pdf_several_pages.pdf';
     const i18n = getI18n();
@@ -287,6 +292,43 @@ describe('Integration | Infrastructure | Utils | Pdf | Certification Attestation
       referencePdfPath + ' is not generated as expected',
     ).to.be.true;
   });
+
+  describe('when the certification session is version 3', function () {
+    it('should not display the professionalizing certification message in attestation', async function () {
+      // given
+      const professionalizingValidityStartDate = new Date('2022-01-01');
+      const deliveredAfterStartDate = dayjs(professionalizingValidityStartDate).add(1, 'days').toDate();
+
+      const resultCompetenceTree = domainBuilder.buildResultCompetenceTree();
+      const certificateWithoutProfessionalizingMessage = domainBuilder.buildCertificationAttestation({
+        id: 1,
+        firstName: 'Alain',
+        lastName: 'Cendy',
+        resultCompetenceTree,
+        certifiedBadges: [],
+        deliveredAt: deliveredAfterStartDate,
+        version: SESSIONS_VERSIONS.V3,
+      });
+      const referencePdfPath = 'certification-attestation-pdf-v3-without-professionalizing-message_test.pdf';
+      const i18n = getI18n();
+
+      // when
+      const { buffer } = await getCertificationAttestationsPdfBuffer({
+        certificates: [certificateWithoutProfessionalizingMessage],
+        isFrenchDomainExtension: true,
+        i18n,
+        creationDate: new Date('2021-01-01'),
+      });
+
+      await _writeFile(buffer, referencePdfPath);
+
+      // then
+      expect(
+        await isSameBinary(`${__dirname}/${referencePdfPath}`, buffer),
+        referencePdfPath + ' is not generated as expected',
+      ).to.be.true;
+    });
+  });
 });
 
 async function _writeFile(buffer, outputFilename, dryRun = true) {

diff --git a/api/tests/tooling/domain-builder/factory/build-certification-attestation.js b/api/tests/tooling/domain-builder/factory/build-certification-attestation.js
@@ -1,4 +1,5 @@
 import { CertificationAttestation } from '../../../../src/certification/results/domain/models/CertificationAttestation.js';
+import { SESSIONS_VERSIONS } from '../../../../src/certification/shared/domain/models/SessionVersion.js';
 
 const buildCertificationAttestation = function ({
   id = 1,
@@ -16,6 +17,7 @@ const buildCertificationAttestation = function ({
   verificationCode = 'P-SOMECODE',
   certifiedBadges = [],
   resultCompetenceTree = null,
+  version = SESSIONS_VERSIONS.V3,
 } = {}) {
   return new CertificationAttestation({
     id,
@@ -33,6 +35,7 @@ const buildCertificationAttestation = function ({
     verificationCode,
     certifiedBadges,
     resultCompetenceTree,
+    version,
   });
 };