chore(api): replace locals-rules with @1024pix eslint rules

1024pix · Oct 17, 2023 · 361cd4f · 361cd4f
1 parent c26d121
commit 361cd4f
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 24 deletions.
diff --git a/api/.eslintrc.cjs b/api/.eslintrc.cjs
@@ -22,7 +22,7 @@ module.exports = {
   globals: {
     include: true,
   },
-  plugins: ['knex', 'unicorn', 'local-rules'],
+  plugins: ['knex', 'unicorn', '@1024pix'],
   rules: {
     'no-console': 'error',
     'mocha/no-hooks-for-single-case': 'off',
@@ -67,6 +67,6 @@ module.exports = {
         ],
       },
     ],
-    'local-rules/no-sinon-stub-with-args-oneliner': 'error',
+    '@1024pix/no-sinon-stub-with-args-oneliner': 'error',
   },
 };
diff --git a/api/eslint-local-rules.cjs b/api/eslint-local-rules.cjs
diff --git a/api/package-lock.json b/api/package-lock.json
diff --git a/api/package.json b/api/package.json
@@ -86,7 +86,7 @@
   },
   "devDependencies": {
     "@1024pix/eslint-config": "^1.0.3",
-    "@1024pix/eslint-plugin-no-sinon-stub-with-args-oneliner": "^0.2.0",
+    "@1024pix/eslint-plugin": "^1.0.0",
     "@babel/eslint-parser": "^7.18.2",
     "@babel/plugin-syntax-import-assertions": "^7.20.0",
     "@ls-lint/ls-lint": "^2.0.0",
@@ -100,7 +100,6 @@
     "eslint-plugin-i18n-json": "^4.0.0",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-knex": "https://github.com/1024pix/eslint-plugin-knex#master",
-    "eslint-plugin-local-rules": "^2.0.0",
     "eslint-plugin-mocha": "^10.0.5",
     "eslint-plugin-n": "^16.0.0",
     "eslint-plugin-prettier": "^5.0.0",

diff --git a/api/tests/unit/scripts/helpers/organizations-by-external-id-helper_test.js b/api/tests/unit/scripts/helpers/organizations-by-external-id-helper_test.js
@@ -45,7 +45,7 @@ describe('Unit | Scripts | organizations-by-external-id-helper.js', function ()
       ];
 
       // TODO: Fix this the next time the file is edited.
-      // eslint-disable-next-line local-rules/no-sinon-stub-with-args-oneliner
+      // eslint-disable-next-line @1024pix/no-sinon-stub-with-args-oneliner
       const findByExternalIdsFetchingIdsOnlyStub = sinon.stub().withArgs(['A100', 'B200']).resolves([]);
       const organizationRepository = { findByExternalIdsFetchingIdsOnly: findByExternalIdsFetchingIdsOnlyStub };