♿️ certif: add aria-label for footer navigation

1024pix · Dec 17, 2024 · 1bc8716 · 1bc8716
1 parent 2b4ed7a
commit 1bc8716
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/certif/app/components/layout/footer.gjs b/certif/app/components/layout/footer.gjs
@@ -21,7 +21,7 @@ export default class Footer extends Component {
 
   <template>
     <footer class='footer'>
-      <nav class='footer__navigation'>
+      <nav class='footer__navigation' aria-label={{t 'navigation.footer.aria-label'}}>
         <ul class='footer__navigation-list'>
           <li>
             <a href={{this.legalNoticeUrl}} target='_blank' class='footer-navigation__item' rel='noopener noreferrer'>

diff --git a/certif/tests/integration/components/layout/footer_test.gjs b/certif/tests/integration/components/layout/footer_test.gjs
@@ -1,4 +1,4 @@
-import { render } from '@1024pix/ember-testing-library';
+import { render, within } from '@1024pix/ember-testing-library';
 import { t } from 'ember-intl/test-support';
 import Footer from 'pix-certif/components/layout/footer';
 import { module, test } from 'qunit';
@@ -30,8 +30,9 @@ module('Integration | Component | Layout | Footer', function (hooks) {
     const screen = await render(<template><Footer /></template>);
 
     // then
+    const footerNavigation = screen.getByRole('navigation', {name: t('navigation.footer.aria-label')});
     assert
-      .dom(screen.getByRole('link', { name: t('navigation.footer.legal-notice') }))
+      .dom(within(footerNavigation).getByRole('link', { name: t('navigation.footer.legal-notice') }))
       .hasAttribute('href', 'https://pix.fr/mentions-legales');
   });
 
@@ -44,8 +45,9 @@ module('Integration | Component | Layout | Footer', function (hooks) {
     const screen = await render(<template><Footer /></template>);
 
     // then
+    const footerNavigation = screen.getByRole('navigation', {name: t('navigation.footer.aria-label')});
     assert
-      .dom(screen.getByRole('link', { name: t('navigation.footer.a11y') }))
+      .dom(within(footerNavigation).getByRole('link', { name: t('navigation.footer.a11y') }))
       .hasAttribute('href', 'https://pix.fr/accessibilite-pix-certif');
   });
 });
diff --git a/certif/translations/en.json b/certif/translations/en.json
@@ -203,6 +203,7 @@
     "external-link-title": "Open in a new window",
     "footer": {
       "a11y": "Accessibility",
+      "aria-label": "Footer navigation",
       "current-year": "© {currentYear} Pix",
       "legal-notice": "Legal notice"
     },

diff --git a/certif/translations/fr.json b/certif/translations/fr.json
@@ -203,6 +203,7 @@
     "external-link-title": "Ouverture dans une nouvelle fenêtre",
     "footer": {
       "a11y": "Accessibilité : partiellement conforme",
+      "aria-label": "Navigation de pied de page",
       "current-year": "© {currentYear} Pix",
       "legal-notice": "Mentions légales"
     },