Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add area calculator #273

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Ashish4321-hub
Copy link

@Ashish4321-hub Ashish4321-hub commented Apr 27, 2022

Description πŸ“œ

area calculator is created for telling the area of rectangle,circle and square.
#265


Checklist βœ…

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GSSOC'22 contributor

@awesome-bot-app
Copy link


Thanks for opening the pull request @Ashish4321-hub! I will look into it ASAP!
Till then you can improve your code & you can show your love by staring my repos πŸ˜‹.

Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not contain README.md file and screenshot of your project.

@mansi-garg-12 mansi-garg-12 added changes Changes Requested and removed review_needed labels Apr 29, 2022
@Ashish4321-hub
Copy link
Author

Screenshot of project
calculator

@Ashish4321-hub
Copy link
Author

@mansi-garg-12 I add README.md file and screenshot of your project.

@Ashish4321-hub Ashish4321-hub marked this pull request as draft May 1, 2022 06:44
@Ashish4321-hub Ashish4321-hub marked this pull request as ready for review May 1, 2022 06:45
Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more features in your PR As this type of calculator already exist.

@Ashish4321-hub
Copy link
Author

add 13 geometry shapes with their description and calculator of their area
area
araea

@Ashish4321-hub
Copy link
Author

@mansi-garg-12 now check it

Copy link
Collaborator

@mansi-garg-12 mansi-garg-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have made too many html file you have to made a single HTML file and all calculator in single web page.

@Ashish4321-hub
Copy link
Author

I add all calculator in single html file.

area
image

@Ashish4321-hub
Copy link
Author

@mansi-garg-12 is it ok now?

Copy link
Owner

@0xvashishth 0xvashishth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be having only one html, one css, and one jaascript file in your pr.
In your case remove shape.html and anyone css file.
And make it responsive :) @Ashish4321-hub

@0xvashishth
Copy link
Owner

@Ashish4321-hub is there any updates ?

@Ashish4321-hub
Copy link
Author

@vasu-1 i add all required things in html ,js ,css file

Copy link
Owner

@0xvashishth 0xvashishth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename shape.html to index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes Changes Requested GSSoC22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants