-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add area calculator #273
base: main
Are you sure you want to change the base?
add area calculator #273
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not contain README.md file and screenshot of your project.
@mansi-garg-12 I add README.md file and screenshot of your project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some more features in your PR As this type of calculator already exist.
@mansi-garg-12 now check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have made too many html file you have to made a single HTML file and all calculator in single web page.
@mansi-garg-12 is it ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be having only one html
, one css
, and one jaascript
file in your pr.
In your case remove shape.html
and anyone css
file.
And make it responsive :) @Ashish4321-hub
@Ashish4321-hub is there any updates ? |
@vasu-1 i add all required things in html ,js ,css file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename shape.html
to index.html
Description π
area calculator is created for telling the area of rectangle,circle and square.
#265
Checklist β