-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign send confirmation #969
base: dev
Are you sure you want to change the base?
Conversation
}} | ||
> | ||
<XStack gap={'$4'} ai={'center'}> | ||
<AvatarProfile profile={profile} size={'$3'} mx="none" circular /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use <LinkableAvatar/>
here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied
@@ -75,7 +75,7 @@ export function SendTopNav() { | |||
{(() => { | |||
switch (true) { | |||
case path.includes('/confirm'): | |||
return 'Preview And Send' | |||
return 'Recipient' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Designs are a little off here. Let's change this to Review Transfer and remove the other instance of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied what was discussed on qa channel
)} | ||
<YStack gap={'$4'}> | ||
<Paragraph size={'$8'} mt={'$4'}> | ||
Review transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied what was discussed on qa channel
995008a
to
ed2dc1f
Compare
Vercel Unique URL: https://sendapp-36h7jntz3-0xsend.vercel.app |
Playwright ReportSummary
Suitesaccount-rewards.onboarded.spec.tscan visit rewards page
account-sendtag-checkout.onboarded.spec.tscan visit checkout page
can add a pending tag
cannot add an invalid tag name
can confirm a tag
can refer a tag
can refer multiple tags in separate transactions
cannot confirm a tag without paying
cannot add more than 5 tags
account-settings-backup.onboarded.spec.tscan backup account
can remove a signer
account.logged-in.spec.tscan visit account page
can update profile
activity.onboarded.spec.tscan visit activity page and see correct activity feed
can search on activity page
home.onboarded.spec.tscan visit token detail page
leaderboard.logged-in.spec.tscan visit leaderboard page
onboarding.logged-in.spec.tscan visit onboarding page
profile.anon.spec.tsanon user can visit public profile
anon user cannot visit private profile
profile.logged-in.spec.tslogged in user needs onboarding before visiting profile
profile.onboarded.spec.tscan visit other user profile and send by tag
can visit my own profile
can visit private profile
can view activities between another profile
send.onboarded.spec.tscan send USDC starting from profile page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send USDC using tag starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send USDC using sendid starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send USDC using address starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send ETH starting from profile page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send ETH using tag starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send ETH using sendid starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send ETH using address starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send SEND starting from profile page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send SEND using tag starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send SEND using sendid starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
can send SEND using address starting from home page
Locator: locator('h2').filter({ hasText: 'Recipient' }) at fixtures/send/page.ts:33 �[0m �[90m 31 |�[39m
sign-in.anon.spec.tsredirect on sign-in
redirect to send confirm page on sign-in
sign-up.anon.spec.tscan sign up
country code is selected based on geoip
skip otp for existing user trying to sign up using already used phone number
user can sign in with passkey from backing up page
user can sign in as back up using otp from backing up page
|
No description provided.