Fix mobile button row refetches and fix types #962
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| const canSubmit = | ||
| !isLoadingCoins && | ||
| balance !== undefined && | ||
| coin?.balance !== undefined && | ||
| sendParams.amount !== undefined && | ||
| balance >= parsedAmount && | ||
| coin.balance >= parsedAmount && | ||
| parsedAmount > BigInt(0) |
There was a problem hiding this comment.
The canSubmit condition should be updated to properly handle cases where coin might be undefined. Change to: const canSubmit = !isLoadingCoins && coin !== undefined && coin.balance !== undefined && sendParams.amount !== undefined && coin.balance >= parsedAmount && parsedAmount > BigInt(0)
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
youngkidwarrior
force-pushed
the
fix_mobile_button_row_refetches_and_fix_types
branch
from
669193d to
bfe64dd
Compare
|
Vercel Unique URL: https://sendapp-10mjykth2-0xsend.vercel.app |
Playwright ReportSummary
Suitesaccount-rewards.onboarded.spec.tscan visit rewards page
account-sendtag-checkout.onboarded.spec.tscan visit checkout page
can add a pending tag
cannot add an invalid tag name
can confirm a tag
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m can refer a tag
can refer multiple tags in separate transactions
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m cannot confirm a tag without paying
cannot add more than 5 tags
account-settings-backup.onboarded.spec.tscan backup account
can remove a signer
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m account.logged-in.spec.tscan visit account page
can update profile
activity.onboarded.spec.tscan visit activity page and see correct activity feed
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m can search on activity page
home.onboarded.spec.tscan visit token detail page
leaderboard.logged-in.spec.tscan visit leaderboard page
onboarding.logged-in.spec.tscan visit onboarding page
profile.anon.spec.tsanon user can visit public profile
Call log: �[0m �[90m 27 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(profile�[33m.�[39mname))�[33m.�[39mtoBeVisible()
Call log: �[0m �[90m 27 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(profile�[33m.�[39mname))�[33m.�[39mtoBeVisible() anon user cannot visit private profile
profile.logged-in.spec.tslogged in user needs onboarding before visiting profile
Call log: �[0m �[90m 34 |�[39m expect(�[36mawait�[39m page�[33m.�[39mtitle())�[33m.�[39mtoBe(�[32m'Send | Profile'�[39m)
Call log: �[0m �[90m 34 |�[39m expect(�[36mawait�[39m page�[33m.�[39mtitle())�[33m.�[39mtoBe(�[32m'Send | Profile'�[39m) profile.onboarded.spec.tscan visit other user profile and send by tag
can visit my own profile
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m can visit private profile
�[0m �[90m 30 |�[39m �[36mreturn�[39m �[36mfalse�[39m can view activities between another profile
send.onboarded.spec.tscan send USDC starting from profile page
Call log: �[0m �[90m 42 |�[39m }) can send USDC using tag starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send USDC using sendid starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send USDC using address starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send ETH starting from profile page
Call log: �[0m �[90m 42 |�[39m }) can send ETH using tag starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send ETH using sendid starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send ETH using address starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send SEND starting from profile page
Call log: �[0m �[90m 42 |�[39m }) can send SEND using tag starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send SEND using sendid starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) can send SEND using address starting from home page
Locator: getByRole('button', { name: 'Continue' }) at fixtures/send/page.ts:37 �[0m �[90m 35 |�[39m �[36mawait�[39m �[36mthis�[39m�[33m.�[39mamountInput�[33m.�[39mfill(amount) sign-in.anon.spec.tsredirect on sign-in
redirect to send confirm page on sign-in
sign-up.anon.spec.tscan sign up
country code is selected based on geoip
skip otp for existing user trying to sign up using already used phone number
user can sign in with passkey from backing up page
user can sign in as back up using otp from backing up page
|
No description provided.