lock and earn #742

stormcloud266 · 2024-10-02T23:57:19Z

stormcloud266 · 2024-10-02T23:57:36Z

open position UI #759
lock and earn #742 👈 (View in Graphite)
rewards landing #730 : 1 other dependent PR (#767 )
Refactor UseReferralsCount query and Types #748 : 1 other dependent PR (#716 )
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

youngkidwarrior

lets sync this with new changes, then i'll review

youngkidwarrior · 2024-10-10T10:02:18Z

packages/app/features/account/rewards/lock-and-earn/screen.tsx

+import { useState } from 'react'
+import { useThemeSetting } from 'app/provider/theme'
+
+const ScrollLayout = ({ children }) => {


I believe this is trying to do a bottom button row on mobile? If so we have an layout for this already. You can check it out here

https://github.com/0xsend/sendapp/blob/ee4e44920146d89e557ee303cb4e56db53af207d/apps/next/pages/%5Btag%5D.tsx#L85C1-L92C1

thanks that's what i was missing

youngkidwarrior

This looks like a good start. Time to dive into the functionality with Zigg so we can things rockin and rollin. I recommend diving into the uniswapV2 docs alongside Zigg's code to get a better picture of what's required.

github-actions · 2024-10-23T23:53:49Z

Vercel Unique URL: https://sendapp-odfne7745-0xsend.vercel.app
Vercel Preview URL: sendapp-10-02-lock-and-earn-0xsend.vercel.app
Last Commit: d211c0c

github-actions · 2024-10-24T00:23:42Z

Playwright Report

Summary

Expected	Skipped	Unexpected	Flaky	Duration
15	0	75	0	1528.54s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

chromium: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByRole('heading', { name: 'Claim Your Network Benefits' })
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByRole('heading', { name: 'Claim Your Network Benefits' })�[22m

�[0m �[90m 14 |�[39m �[36mawait�[39m expect(page)�[33m.�[39mtoHaveURL(�[32m'/account/rewards'�[39m)
�[90m 15 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(�[32m'Rewards'�[39m�[33m,�[39m { exact�[33m:�[39m �[36mtrue�[39m }))�[33m.�[39mtoBeVisible()
�[31m�[1m>�[22m�[39m�[90m 16 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByRole(�[32m'heading'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Claim Your Network Benefits'�[39m }))�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 17 |�[39m })
�[90m 18 |�[39m�[0m

at /opt/actions_runner/_work/sendapp/sendapp/packages/playwright/tests/account-rewards.onboarded.spec.ts:16:84

firefox: ❌

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

chromium: ✅
firefox: ❌

can add a pending tag

chromium: ✅
firefox: ❌

cannot add an invalid tag name

chromium: ✅
firefox: ❌

can confirm a tag

chromium: ✅
firefox: ❌

can refer a tag

chromium: ✅
firefox: ❌

can refer multiple tags in separate transactions

chromium: ✅
firefox: ❌

cannot confirm a tag without paying

chromium: ✅
firefox: ❌

cannot add more than 5 tags

chromium: ✅
firefox: ❌

account-settings-backup.onboarded.spec.ts

can backup account

chromium: ✅
firefox: ❌

can remove a signer

chromium: ✅
firefox: ❌

account.logged-in.spec.ts

can visit account page

chromium: ✅
firefox: ❌

can update profile

chromium: ❌
firefox: ❌

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

chromium: ❌
firefox: ❌

can search on activity page

chromium: ❌
firefox: ❌

home.onboarded.spec.ts

can visit token detail page

chromium: ❌
firefox: ❌

leaderboard.logged-in.spec.ts

can visit leaderboard page

chromium: ❌
firefox: ❌

onboarding.logged-in.spec.ts

can visit onboarding page

chromium: ❌
firefox: ❌

profile.anon.spec.ts

anon user can visit public profile

chromium: ✅
firefox: ✅

anon user cannot visit private profile

chromium: ✅
firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

chromium: ❌
firefox: ❌

profile.onboarded.spec.ts

can visit other user profile and send by tag

chromium: ❌
firefox: ❌

can visit my own profile

chromium: ❌
firefox: ❌

can visit private profile

chromium: ❌
firefox: ❌

can view activities between another profile

chromium: ❌
firefox: ❌

send.onboarded.spec.ts

can send USDC starting from profile page

chromium: ❌
firefox: ❌

can send USDC using tag starting from home page

chromium: ❌
firefox: ❌

can send USDC using sendid starting from home page

chromium: ❌
firefox: ❌

can send USDC using address starting from home page

chromium: ❌
firefox: ❌

can send ETH starting from profile page

chromium: ❌
firefox: ❌

can send ETH using tag starting from home page

chromium: ❌
firefox: ❌

can send ETH using sendid starting from home page

chromium: ❌
firefox: ❌

can send ETH using address starting from home page

chromium: ❌
firefox: ❌

can send SPX starting from profile page

chromium: ❌
firefox: ❌

can send SPX using tag starting from home page

chromium: ❌
firefox: ❌

can send SPX using sendid starting from home page

chromium: ❌
firefox: ❌

can send SPX using address starting from home page

chromium: ❌
firefox: ❌

can send SEND starting from profile page

chromium: ❌
firefox: ❌

can send SEND using tag starting from home page

chromium: ❌
firefox: ❌

can send SEND using sendid starting from home page

chromium: ❌
firefox: ❌

can send SEND using address starting from home page

chromium: ❌
firefox: ❌

sign-in.anon.spec.ts

redirect on sign-in

chromium: ❌
firefox: ❌

redirect to send confirm page on sign-in

chromium: ❌
firefox: ❌

sign-up.anon.spec.ts

can sign up

chromium: ❌
firefox: ❌

country code is selected based on geoip

chromium: ❌
firefox: ❌

stormcloud266 mentioned this pull request Oct 2, 2024

rewards landing #730

Merged

stormcloud266 force-pushed the 09-23-rewards_landing branch from 6145f95 to 2d09578 Compare October 4, 2024 00:45

stormcloud266 force-pushed the 10-02-lock_and_earn branch from c413d36 to ac73892 Compare October 4, 2024 00:45

stormcloud266 force-pushed the 09-23-rewards_landing branch from 2d09578 to 08e6611 Compare October 4, 2024 00:46

stormcloud266 force-pushed the 10-02-lock_and_earn branch from ac73892 to e4a098e Compare October 4, 2024 00:46

stormcloud266 force-pushed the 09-23-rewards_landing branch from 08e6611 to cc82f49 Compare October 4, 2024 00:55

stormcloud266 force-pushed the 10-02-lock_and_earn branch from e4a098e to 85aa43a Compare October 4, 2024 00:55

This was referenced Oct 4, 2024

Activity Rewards Page #743

Merged

Activity Rewards Header #744

Merged

Activity Rewards Distribution Select #745

Merged

Activity Rewards distribution requirements card #746

Merged

Rewards Activity Create Passkey Perk Card #747

Closed

stormcloud266 force-pushed the 09-23-rewards_landing branch from cc82f49 to 700af01 Compare October 4, 2024 23:56

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 85aa43a to f4a7f1e Compare October 4, 2024 23:56

stormcloud266 force-pushed the 09-23-rewards_landing branch from 700af01 to 74a4b4b Compare October 5, 2024 00:02

stormcloud266 force-pushed the 10-02-lock_and_earn branch from f4a7f1e to 6f399ac Compare October 5, 2024 00:02

youngkidwarrior force-pushed the 09-23-rewards_landing branch from 74a4b4b to eeb8b6d Compare October 5, 2024 00:37

youngkidwarrior mentioned this pull request Oct 5, 2024

Refactor UseReferralsCount query and Types #748

Merged

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 6f399ac to b8b640f Compare October 5, 2024 00:43

stormcloud266 force-pushed the 09-23-rewards_landing branch from eeb8b6d to 3b6644a Compare October 5, 2024 00:45

stormcloud266 force-pushed the 10-02-lock_and_earn branch from b8b640f to 376ed88 Compare October 5, 2024 00:45

stormcloud266 force-pushed the 09-23-rewards_landing branch from 3b6644a to cedb98b Compare October 5, 2024 00:49

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 376ed88 to 0be2e9e Compare October 5, 2024 00:49

stormcloud266 marked this pull request as ready for review October 5, 2024 00:51

stormcloud266 requested a review from 0xBigBoss as a code owner October 5, 2024 00:51

stormcloud266 requested a review from youngkidwarrior October 5, 2024 00:51

youngkidwarrior force-pushed the 09-23-rewards_landing branch 3 times, most recently from a13452a to 13a6859 Compare October 5, 2024 01:57

youngkidwarrior force-pushed the 09-23-rewards_landing branch from 13a6859 to c6d1fc8 Compare October 5, 2024 21:18

youngkidwarrior reviewed Oct 5, 2024

View reviewed changes

youngkidwarrior force-pushed the 09-23-rewards_landing branch 2 times, most recently from 9e9bf69 to f9a01bc Compare October 5, 2024 22:30

youngkidwarrior force-pushed the 10-02-lock_and_earn branch from 0be2e9e to 379db5b Compare October 5, 2024 22:31

stormcloud266 force-pushed the 09-23-rewards_landing branch from f9a01bc to c7e1754 Compare October 7, 2024 23:00

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 379db5b to 43595bf Compare October 7, 2024 23:00

stormcloud266 requested a review from youngkidwarrior October 7, 2024 23:08

youngkidwarrior reviewed Oct 10, 2024

View reviewed changes

stormcloud266 mentioned this pull request Oct 12, 2024

open position UI #759

Open

youngkidwarrior force-pushed the 09-23-rewards_landing branch from c7e1754 to 76d689b Compare October 18, 2024 00:47

Base automatically changed from 09-23-rewards_landing to dev October 18, 2024 09:36

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 43595bf to 6406e4b Compare October 23, 2024 23:12

lock and earn

d211c0c

stormcloud266 force-pushed the 10-02-lock_and_earn branch from 6406e4b to d211c0c Compare October 23, 2024 23:43

stormcloud266 requested a review from youngkidwarrior October 23, 2024 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lock and earn #742

lock and earn #742

stormcloud266 commented Oct 2, 2024 •

edited

Loading

stormcloud266 commented Oct 2, 2024 •

edited by youngkidwarrior

Loading

youngkidwarrior left a comment

youngkidwarrior Oct 10, 2024

stormcloud266 Oct 23, 2024

youngkidwarrior left a comment

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 24, 2024

lock and earn #742

Are you sure you want to change the base?

lock and earn #742

Conversation

stormcloud266 commented Oct 2, 2024 • edited Loading

stormcloud266 commented Oct 2, 2024 • edited by youngkidwarrior Loading

youngkidwarrior left a comment

Choose a reason for hiding this comment

youngkidwarrior Oct 10, 2024

Choose a reason for hiding this comment

stormcloud266 Oct 23, 2024

Choose a reason for hiding this comment

youngkidwarrior left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 24, 2024

Playwright Report

Summary

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

can add a pending tag

cannot add an invalid tag name

can confirm a tag

can refer a tag

can refer multiple tags in separate transactions

cannot confirm a tag without paying

cannot add more than 5 tags

account-settings-backup.onboarded.spec.ts

can backup account

can remove a signer

account.logged-in.spec.ts

can visit account page

can update profile

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

can search on activity page

home.onboarded.spec.ts

can visit token detail page

leaderboard.logged-in.spec.ts

can visit leaderboard page

onboarding.logged-in.spec.ts

can visit onboarding page

profile.anon.spec.ts

anon user can visit public profile

anon user cannot visit private profile

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

profile.onboarded.spec.ts

can visit other user profile and send by tag

can visit my own profile

can visit private profile

can view activities between another profile

send.onboarded.spec.ts

can send USDC starting from profile page

can send USDC using tag starting from home page

can send USDC using sendid starting from home page

can send USDC using address starting from home page

can send ETH starting from profile page

can send ETH using tag starting from home page

can send ETH using sendid starting from home page

can send ETH using address starting from home page

can send SPX starting from profile page

can send SPX using tag starting from home page

can send SPX using sendid starting from home page

can send SPX using address starting from home page

can send SEND starting from profile page

can send SEND using tag starting from home page

can send SEND using sendid starting from home page

can send SEND using address starting from home page

sign-in.anon.spec.ts

redirect on sign-in

redirect to send confirm page on sign-in

sign-up.anon.spec.ts

can sign up

country code is selected based on geoip

stormcloud266 commented Oct 2, 2024 •

edited

Loading

stormcloud266 commented Oct 2, 2024 •

edited by youngkidwarrior

Loading