/send checks create/claim shovel integrations #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xBigBoss
reviewed
Aug 9, 2024
nicky-LV
force-pushed
the
feat/send-checks-manage
branch
from
9bec9fd to
cfacb7b
Compare
nicky-LV
commented
Aug 9, 2024
0xBigBoss
reviewed
Aug 10, 2024
supabase/migrations/20240809183933_update_send_check_created_table_use_event_id.sql
Outdated
Show resolved
Hide resolved
0xBigBoss
reviewed
Aug 10, 2024
0xBigBoss
reviewed
Aug 10, 2024
supabase/migrations/20240809183933_update_send_check_created_table_use_event_id.sql
Outdated
Show resolved
Hide resolved
0xBigBoss
reviewed
Aug 10, 2024
0xBigBoss
reviewed
Aug 10, 2024
supabase/migrations/20240809190723_update_send_check_claimed_table_use_event_id.sql
Outdated
Show resolved
Hide resolved
nicky-LV
force-pushed
the
feat/send-checks-manage
branch
from
cfacb7b to
82c4e97
Compare
|
Vercel Unique URL: https://sendapp-gepp45od1-0xsend.vercel.app |
0xBigBoss
reviewed
Aug 10, 2024
| -- Policy for viewing claimed checks: Users can only select their own claimed checks | ||
| CREATE POLICY "Users can see their own claimed checks" ON "public"."send_check_claimed" FOR | ||
| SELECT USING ( | ||
| lower(concat('0x', encode(send_check_claimed.redeemer, 'hex')))::citext in ( |
There was a problem hiding this comment.
Let's add an OR also checking the from. Users should be able to see their claimed checks.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| select user_id into _f_user_id from send_accounts where address = concat('0x', encode(NEW.from, 'hex'))::citext; | ||
|
|
||
| -- populate t_user_id with receiver's user_id | ||
| select user_id into _t_user_id from send_accounts where address = concat('0x', encode(NEW.reedeemer, 'hex'))::citext; |
There was a problem hiding this comment.
The column name reedeemer in this query is misspelled - it should be redeemer to match the corresponding column name in the send_check_claimed table.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: