Simplify confirm screen param validation

[youngkidwarrior]

No description provided.

[youngkidwarrior]

• Simplify confirm screen param validation #601 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @youngkidwarrior and the rest of your teammates on Graphite

[github-actions]

Vercel Unique URL: https://sendapp-rkr5s50os-0xsend.vercel.app
Vercel Preview URL: sendapp-simplify-confirm-screen-param-validation-0xsend.vercel.app
Last Commit: 3b0f471

[github-actions]

Playwright Report

Summary

Expected	Skipped	Unexpected	Flaky	Duration
78	0	2	2	326.49s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

• chromium: ✅
• firefox: ✅

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

• chromium: ✅
• firefox: ✅

can add a pending tag

• chromium: ✅
• firefox: ✅

cannot add an invalid tag name

• chromium: ✅
• firefox: ✅

can confirm a tag

• chromium: ✅
• firefox: ✅

can refer a tag

• chromium: ✅
• firefox: 🚨

cannot confirm a tag without paying

• chromium: ✅
• firefox: ✅

cannot add more than 5 tags

• chromium: ✅
• firefox: ✅

account-settings-backup.onboarded.spec.ts

can backup account

• chromium: ✅
• firefox: 🚨

can remove a signer

• chromium: ✅
• firefox: ✅

account.logged-in.spec.ts

can visit account page

• chromium: ✅
• firefox: ✅

can update profile

• chromium: ✅
• firefox: ✅

activity.onboarded.spec.ts

can visit activity page

• chromium: ✅
• firefox: ✅

can search on activity page

• chromium: ✅
• firefox: ✅

deposit.onboarded.spec.ts

can deposit USDC with web3 wallet

• chromium: ✅
• firefox: ✅

can deposit ETH with web3 wallet

• chromium: ✅
• firefox: ✅

home.onboarded.spec.ts

can visit token detail page

• chromium: ✅
• firefox: ✅

onboarding.logged-in.spec.ts

can visit onboarding page

• chromium: ✅
• firefox: ✅

profile.anon.spec.ts

anon user can visit public profile

• chromium: ✅
• firefox: ✅

anon user cannot visit private profile

• chromium: ✅
• firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

• chromium: ✅
• firefox: ✅

profile.onboarded.spec.ts

can visit other user profile and send by tag

• chromium: ✅
• firefox: ✅

can visit my own profile

• chromium: ✅
• firefox: ✅

can visit private profile

• chromium: ✅
• firefox: ✅

can view activities between another profile

• chromium: ✅
• firefox: ✅

send.onboarded.spec.ts

can send USDC starting from profile page

• chromium: ✅
• firefox: ✅

can send USDC using tag starting from send page

• chromium: ✅
• firefox: ✅

can send USDC using sendid starting from send page

• chromium: ✅
• firefox: ✅

can send USDC using address starting from send page

• chromium: ✅
• firefox: ✅

can send ETH starting from profile page

• chromium: ✅
• firefox: ✅

can send ETH using tag starting from send page

• chromium: ✅
• firefox: ✅

can send ETH using sendid starting from send page

• chromium: ✅
• firefox: ✅

can send ETH using address starting from send page

• chromium: ✅
• firefox: ✅

can send SEND starting from profile page

• chromium: ✅
• firefox: ✅

can send SEND using tag starting from send page

• chromium: ✅
• firefox: ✅

can send SEND using sendid starting from send page

• chromium: ✅
• firefox: ✅

can send SEND using address starting from send page

• chromium: ✅
• firefox: ✅

sign-in.anon.spec.ts

redirect on sign-in

• chromium: ❌
  • Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoHaveURL�[2m(�[22m�[32mexpected�[39m�[2m)�[22m

Locator: locator(':root')
Expected string: �[32m"http://localhost:3000/auth/sign-in?redirectUri=�[7m/�[27msend"�[39m
Received string: �[31m"http://localhost:3000/auth/sign-in?redirectUri=�[7m%2F�[27msend"�[39m
Call log:
�[2m- expect.toHaveURL with timeout 5000ms�[22m
�[2m - waiting for locator(':root')�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m

�[0m �[90m 29 |�[39m �[36mawait�[39m page�[33m.�[39mgoto(�[32m'/send'�[39m)
�[90m 30 |�[39m �[90m// redirect to send after user is logged in�[39m
�[31m�[1m>�[22m�[39m�[90m 31 |�[39m �[36mawait�[39m expect(page)�[33m.�[39mtoHaveURL(�[32m'/auth/sign-in?redirectUri=/send'�[39m)
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 32 |�[39m �[36mconst�[39m signInButton �[33m=�[39m page�[33m.�[39mgetByRole(�[32m'button'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Sign In'�[39m })
�[90m 33 |�[39m �[36mawait�[39m expect(signInButton)�[33m.�[39mtoBeVisible()
�[90m 34 |�[39m �[36mawait�[39m signInButton�[33m.�[39mclick()�[0m

at /opt/actions_runner/_work/sendapp/sendapp/packages/playwright/tests/sign-in.anon.spec.ts:31:24

• firefox: ❌
  • Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoHaveURL�[2m(�[22m�[32mexpected�[39m�[2m)�[22m

Locator: locator(':root')
Expected string: �[32m"http://localhost:3000/auth/sign-in?redirectUri=�[7m/�[27msend"�[39m
Received string: �[31m"http://localhost:3000/auth/sign-in?redirectUri=�[7m%2F�[27msend"�[39m
Call log:
�[2m- expect.toHaveURL with timeout 5000ms�[22m
�[2m - waiting for locator(':root')�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m
�[2m - locator resolved to …�[22m
�[2m - unexpected value "http://localhost:3000/auth/sign-in?redirectUri=%2Fsend"�[22m

�[0m �[90m 29 |�[39m �[36mawait�[39m page�[33m.�[39mgoto(�[32m'/send'�[39m)
�[90m 30 |�[39m �[90m// redirect to send after user is logged in�[39m
�[31m�[1m>�[22m�[39m�[90m 31 |�[39m �[36mawait�[39m expect(page)�[33m.�[39mtoHaveURL(�[32m'/auth/sign-in?redirectUri=/send'�[39m)
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 32 |�[39m �[36mconst�[39m signInButton �[33m=�[39m page�[33m.�[39mgetByRole(�[32m'button'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Sign In'�[39m })
�[90m 33 |�[39m �[36mawait�[39m expect(signInButton)�[33m.�[39mtoBeVisible()
�[90m 34 |�[39m �[36mawait�[39m signInButton�[33m.�[39mclick()�[0m

at /opt/actions_runner/_work/sendapp/sendapp/packages/playwright/tests/sign-in.anon.spec.ts:31:24

redirect to send confirm page on sign-in

• chromium: ✅
• firefox: ✅

sign-up.anon.spec.ts

can sign up

• chromium: ✅
• firefox: ✅

country code is selected based on geoip

• chromium: ✅
• firefox: ✅