Applied code review comments

0xsend · Dec 24, 2024 · d94f1c8 · d94f1c8
1 parent 2d78331
commit d94f1c8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/packages/app/features/profile/screen.tsx b/packages/app/features/profile/screen.tsx
@@ -38,7 +38,7 @@ export function ProfileScreen({ sendid: propSendid }: ProfileScreenProps) {
   const { user, profile: currentUserProfile } = useUser()
   const media = useMedia()
   const [queryParams, setRootParams] = useRootScreenParams()
-  const { isProfileInfoVisible } = queryParams
+  const isProfileInfoVisible = queryParams.modal === 'profile'
 
   const {
     data,
@@ -57,7 +57,7 @@ export function ProfileScreen({ sendid: propSendid }: ProfileScreenProps) {
 
   const toggleIsProfileInfoVisible = () => {
     setRootParams(
-      { ...queryParams, isProfileInfoVisible: !isProfileInfoVisible },
+      { ...queryParams, modal: isProfileInfoVisible ? undefined : 'profile' },
       { webBehavior: 'replace' }
     )
   }

diff --git a/packages/app/features/send/SendAmountForm.tsx b/packages/app/features/send/SendAmountForm.tsx
@@ -46,7 +46,7 @@ export function SendAmountForm() {
   const { recipient, idType } = sendParams
   const { data: profile } = useProfileLookup(idType ?? 'tag', recipient ?? '')
   const [queryParams, setRootParams] = useRootScreenParams()
-  const { isProfileInfoVisible } = queryParams
+  const isProfileInfoVisible = queryParams.modal === 'profile'
   const [isInputFocused, setIsInputFocused] = useState<boolean>(false)
   const { resolvedTheme } = useThemeSetting()
   const { coin: usdc } = useCoin('USDC')
@@ -99,7 +99,7 @@ export function SendAmountForm() {
 
   const toggleIsProfileInfoVisible = () => {
     setRootParams(
-      { ...queryParams, isProfileInfoVisible: !isProfileInfoVisible },
+      { ...queryParams, modal: isProfileInfoVisible ? undefined : 'profile' },
       { webBehavior: 'replace' }
     )
   }

diff --git a/packages/app/routers/params.tsx b/packages/app/routers/params.tsx
@@ -8,7 +8,7 @@ export type RootParams = {
   nav?: 'home' | 'settings'
   token?: allCoins[number]['token']
   search?: string
-  isProfileInfoVisible?: boolean
+  modal?: 'profile'
 }
 
 const { useParam: useRootParam, useParams: useRootParams } = createParam<RootParams>()
@@ -31,28 +31,25 @@ const useSearch = () => {
   return [search, setSearchParam] as const
 }
 
-const useIsProfileInfoVisible = () => {
-  const [isProfileInfoVisible, setIsProfileInfoVisible] = useRootParam('isProfileInfoVisible', {
-    initial: undefined,
-    parse: (value) => value === 'true',
-  })
+const useModal = () => {
+  const [modal, setModalParam] = useRootParam('modal')
 
-  return [isProfileInfoVisible, setIsProfileInfoVisible] as const
+  return [modal, setModalParam] as const
 }
 
 export const useRootScreenParams = () => {
   const { setParams } = useRootParams()
   const [nav] = useNav()
   const [token] = useToken()
   const [search] = useSearch()
-  const [isProfileInfoVisible] = useIsProfileInfoVisible()
+  const [modal] = useModal()
 
   return [
     {
       nav,
       token,
       search,
-      isProfileInfoVisible,
+      modal,
     },
     setParams,
   ] as const