Fix: crash when taker address not allowed (#1019)

* stop crashing when takerAddress is invalid
0xProject · Feb 5, 2021 · ca7cd44 · ca7cd44
1 parent 8f66252
commit ca7cd44
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 1 deletion.
diff --git a/graphql/client/types.go b/graphql/client/types.go
@@ -248,6 +248,7 @@ const (
 	RejectedOrderCodeIncorrectExchangeAddress         RejectedOrderCode = "INCORRECT_EXCHANGE_ADDRESS"
 	RejectedOrderCodeSenderAddressNotAllowed          RejectedOrderCode = "SENDER_ADDRESS_NOT_ALLOWED"
 	RejectedOrderCodeDatabaseFullOfOrders             RejectedOrderCode = "DATABASE_FULL_OF_ORDERS"
+	RejectedOrderCodeTakerAddressNotAllowed           RejectedOrderCode = "TAKER_ADDRESS_NOT_ALLOWED"
 	RejectedOrderCodeInvalidSchema                    RejectedOrderCode = "INVALID_SCHEMA"
 )
 

diff --git a/graphql/generated/generated.go b/graphql/generated/generated.go
diff --git a/graphql/gqltypes/conversions.go b/graphql/gqltypes/conversions.go
@@ -346,6 +346,8 @@ func RejectedCodeFromValidatorStatus(status ordervalidator.RejectedOrderStatus)
 		return RejectedOrderCodeSenderAddressNotAllowed, nil
 	case ordervalidator.RODatabaseFullOfOrders.Code:
 		return RejectedOrderCodeDatabaseFullOfOrders, nil
+	case ordervalidator.ROTakerAddressNotAllowed.Code:
+		return RejectedOrderCodeTakerAddressNotAllowed, nil
 	default:
 		return "", fmt.Errorf("unexpected RejectedOrderStatus.Code: %q", status.Code)
 	}

diff --git a/graphql/gqltypes/types_generated.go b/graphql/gqltypes/types_generated.go
diff --git a/graphql/schema.graphql b/graphql/schema.graphql
@@ -285,6 +285,7 @@ enum RejectedOrderCode {
     INCORRECT_EXCHANGE_ADDRESS
     SENDER_ADDRESS_NOT_ALLOWED
     DATABASE_FULL_OF_ORDERS
+    TAKER_ADDRESS_NOT_ALLOWED
 }
 
 type Mutation {

diff --git a/packages/mesh-browser-lite/src/types.ts b/packages/mesh-browser-lite/src/types.ts
@@ -644,6 +644,7 @@ export enum RejectedOrderCode {
     IncorrectExchangeAddress = 'INCORRECT_EXCHANGE_ADDRESS',
     SenderAddressNotAllowed = 'SENDER_ADDRESS_NOT_ALLOWED',
     DatabaseFullOfOrders = 'DATABASE_FULL_OF_ORDERS',
+    TakerAddressNotAllowed = 'TAKER_ADDRESS_NOT_ALLOWED',
 }
 
 /** @ignore */

diff --git a/packages/mesh-graphql-client/src/types.ts b/packages/mesh-graphql-client/src/types.ts
@@ -107,6 +107,7 @@ export enum RejectedOrderCode {
     IncorrectExchangeAddress = 'INCORRECT_EXCHANGE_ADDRESS',
     SenderAddressNotAllowed = 'SENDER_ADDRESS_NOT_ALLOWED',
     DatabaseFullOfOrders = 'DATABASE_FULL_OF_ORDERS',
+    TakerAddressNotAllowed = 'TAKER_ADDRESS_NOT_ALLOWED',
 }
 
 export interface OrderEvent {